Skip to content

fix: Allow unencrypted Snowflake key #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 1 commit into from
Mar 1, 2025
Merged

fix: Allow unencrypted Snowflake key #5097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions sdk/python/feast/infra/utils/snowflake/snowflake_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,22 +513,26 @@ def chunk_helper(lst: pd.DataFrame, n: int) -> Iterator[Tuple[int, pd.DataFrame]


def parse_private_key_path(
private_key_passphrase: str,
private_key_passphrase: Optional[str] = None,
key_path: Optional[str] = None,
private_key_content: Optional[bytes] = None,
) -> bytes:
"""Returns snowflake pkb by parsing and reading either from key path or private_key_content as byte string."""
if private_key_content:
p_key = serialization.load_pem_private_key(
private_key_content,
password=private_key_passphrase.encode(),
password=private_key_passphrase.encode()
if private_key_passphrase is not None
else None,
backend=default_backend(),
)
elif key_path:
with open(key_path, "rb") as key:
p_key = serialization.load_pem_private_key(
key.read(),
password=private_key_passphrase.encode(),
password=private_key_passphrase.encode()
if private_key_passphrase is not None
else None,
backend=default_backend(),
)
else:
Expand Down
71 changes: 71 additions & 0 deletions sdk/python/tests/unit/infra/utils/snowflake/test_snowflake_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
import tempfile
from typing import Optional

import pytest
from cryptography.hazmat.primitives import serialization
from cryptography.hazmat.primitives.asymmetric import rsa

from feast.infra.utils.snowflake.snowflake_utils import parse_private_key_path

PRIVATE_KEY_PASSPHRASE = "test"


def _pem_private_key(passphrase: Optional[str]):
private_key = rsa.generate_private_key(public_exponent=65537, key_size=2048)
return private_key.private_bytes(
encoding=serialization.Encoding.PEM,
format=serialization.PrivateFormat.TraditionalOpenSSL,
encryption_algorithm=(
serialization.BestAvailableEncryption(passphrase.encode())
if passphrase
else serialization.NoEncryption()
),
)


@pytest.fixture
def unencrypted_private_key():
return _pem_private_key(None)


@pytest.fixture
def encrypted_private_key():
return _pem_private_key(PRIVATE_KEY_PASSPHRASE)


def test_parse_private_key_path_key_content_unencrypted(unencrypted_private_key):
parse_private_key_path(
None,
None,
unencrypted_private_key,
)


def test_parse_private_key_path_key_content_encrypted(encrypted_private_key):
parse_private_key_path(
PRIVATE_KEY_PASSPHRASE,
None,
encrypted_private_key,
)


def test_parse_private_key_path_key_path_unencrypted(unencrypted_private_key):
with tempfile.NamedTemporaryFile(mode="wb") as f:
f.write(unencrypted_private_key)
f.flush()
parse_private_key_path(
None,
f.name,
None,
)


def test_parse_private_key_path_key_path_encrypted(encrypted_private_key):
with tempfile.NamedTemporaryFile(mode="wb") as f:
f.write(encrypted_private_key)
f.flush()
parse_private_key_path(
PRIVATE_KEY_PASSPHRASE,
f.name,
None,
)
Loading