Skip to content

Conversation

@franciscojavierarceo
Copy link
Member

@franciscojavierarceo franciscojavierarceo commented Feb 8, 2025

What this PR does / why we need it:

Add retrieve_online_documents_v2 to sqlite-vec

  • docs/reference/alpha-vector-database.md

    • Added a new column Online Read in the vector database support table.
    • Marked SQLite as supporting retrieve_online_documents_v2.
    • Noted that both Milvus and SQLite implement the retrieve_online_documents_v2 method.
  • sdk/python/feast/infra/online_stores/sqlite.py

    • Added new attributes to the SqliteOnlineStoreConfig class for vector search.
    • Modified _get_conn method to conditionally enable SQLite vector extension.
    • Refactored retrieve_online_documents to use vec_table.
    • Added a new method retrieve_online_documents_v2 for vector similarity search.
    • Updated _initialize_conn method to handle the vector extension initialization.
  • sdk/python/tests/unit/online_store/test_online_retrieval.py

    • Added a new test test_sqlite_get_online_documents_v2 to ensure the new vector search functionality works as expected.

Notes:

  • The new vector search functionality is only enabled for Python 3.10.
  • Ensure the sqlite_vec extension is available in the environment to utilize the new vector search features.

Which issue(s) this PR fixes:

N/A

Misc

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
@franciscojavierarceo franciscojavierarceo requested a review from a team as a code owner February 8, 2025 19:06
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
@franciscojavierarceo franciscojavierarceo changed the title feat: Add SQLite Offline store feat: Add SQLite retrieve_online_documents_v2 Feb 9, 2025
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Copy link
Collaborator

@shuchu shuchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@franciscojavierarceo franciscojavierarceo merged commit 0fffe21 into master Feb 16, 2025
34 checks passed
franciscojavierarceo pushed a commit that referenced this pull request Feb 17, 2025
# [0.46.0](v0.45.0...v0.46.0) (2025-02-17)

### Bug Fixes

* Add scylladb to online stores list in docs ([#5061](#5061)) ([08183ed](08183ed))
* Changed feast operator to set status of featurestore cr to ready based on deployment.status = available ([#5020](#5020)) ([fce0d35](fce0d35))
* Ensure Postgres queries are committed or autocommit is used ([#5039](#5039)) ([46f8d7a](46f8d7a))
* Fixing the release workflow to refresh the stable branch when the release is not running in the dry run mode. ([#5057](#5057)) ([a13fa9b](a13fa9b))
* Operator - make onlineStore the default service ([#5044](#5044)) ([6c92447](6c92447))
* Operator - resolve infinite reconciler loop in authz controller ([#5056](#5056)) ([11e4548](11e4548))
* Resolve module on windows ([#4827](#4827)) ([efbffa4](efbffa4))
* Setting the github_token explicitly to see if that solves the problem. ([#5012](#5012)) ([3834ffa](3834ffa))
* Validate entities when running get_online_features ([#5031](#5031)) ([3bb0dca](3bb0dca))

### Features

* Add SQLite retrieve_online_documents_v2 ([#5032](#5032)) ([0fffe21](0fffe21))
* Adding Click command to display configuration details ([#5036](#5036)) ([ae68e4d](ae68e4d))
* Adding volumes and volumeMounts support to Feature Store CR. ([#4983](#4983)) ([ec6f1b7](ec6f1b7))
* Moving the job to seperate action so that we can test it easily. ([#5013](#5013)) ([b9325b7](b9325b7))
* Operator - make server container creation explicit in the CR ([#5024](#5024)) ([b16fb40](b16fb40))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants