Relax fastavro version requirement in Feast Python SDK#500
Merged
feast-ci-bot merged 1 commit intofeast-dev:masterfrom Mar 5, 2020
Merged
Conversation
davidheryanto
requested review from
khorshuheng,
pradithya,
woop and
zhilingc
as code owners
Member
|
So |
davidheryanto
force-pushed
the
update-fastavro-version-requirement
branch
from
0ca3472 to
78bb81d
Compare
Collaborator
Author
|
Yes I updated the version range to |
woop
approved these changes
Mar 5, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidheryanto, woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
khorshuheng
pushed a commit
to khorshuheng/feast
that referenced
this pull request
Mar 17, 2020
khorshuheng
pushed a commit
that referenced
this pull request
Mar 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fastavroversion requirement in Feast Python SDK so we can get the latestfastavroupdates and do not force users who already have newer versions offastavroto downgrade, in order to install Feast Python SDK.Recently, we fix to
fastavro==0.22.9becausefastavro==0.22.10uses its internal implementation to represent UTC timezone but it is not compatible with Pandas.fastavro==0.22.11reverts this to usepytzimplementation which is compatible with Pandas.fastavro/fastavro#396
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: