Backport commits from master to v0.4 branch for v0.4.6 release#496
Merged
zhilingc merged 13 commits intofeast-dev:v0.4-branchfrom Feb 26, 2020
Merged
Conversation
(cherry picked from commit 65f2ad7)
(cherry picked from commit fb39c6c)
…feast-dev#481) (cherry picked from commit 887f9e3)
(cherry picked from commit aec7979)
* Fail formatting check before tests execute By default, the spotless Maven plugin binds its check goal to the verify phase (late in the lifecycle, after integration tests). Because we currently only run `mvn test` for CI, it doesn't proceed as far as verify so missed formatting is not caught by CI. This binds the check to an earlier phase, in between test-compile and test, so that it will fail before `mvn test` but not disrupt your dev workflow of compiling main and test sources as you work. This strikes a good compromise on failing fast for code standards without being _too_ nagging. For the complete lifecycle reference, see: https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html * Apply spotless formatting (cherry picked from commit 6363540)
…ast-dev#490) * Fix fastavro version used in feast to 0.22.9 * Print python packages version used when e2e test fails (cherry picked from commit 7586da6)
(cherry picked from commit c3591ed)
…s to StatsD (feast-dev#486) * Extend WriteMetricsTransform to write feature value stats to StatsD * Apply mvn spotless * Catch all exception not just StatsDClientException during init Since there are other exception like UnknownHostException that can be thrown and we want to know such error. Also change the log level to error because so it's not normal for client to fail to be created" * Change log level due to invalid feature set ref to error (previously warn) On 2nd thought, this should constitute an error not a warning * Apply maven spotless to metric transform codes (cherry picked from commit 5508c92)
* Allow use of secure gRPC in Feast Python client. * Add tests for secure gRPC in Python client. (cherry picked from commit a576a53)
So that it is consistent with the actual unit of timing being measured And recommended metric names in Prometheus https://prometheus.io/docs/practices/naming/#metric-names (cherry picked from commit 5758d99)
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidheryanto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Backport changes from
mastertov0.4-branchforv0.4.6release