Skip to content

Backport commits from master to v0.4 branch for v0.4.6 release#496

Merged
zhilingc merged 13 commits intofeast-dev:v0.4-branchfrom
davidheryanto:backport-from-master-to-v0.4-for-v0.4.6-release
Feb 26, 2020
Merged

Backport commits from master to v0.4 branch for v0.4.6 release#496
zhilingc merged 13 commits intofeast-dev:v0.4-branchfrom
davidheryanto:backport-from-master-to-v0.4-for-v0.4.6-release

Conversation

@davidheryanto
Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
Backport changes from master to v0.4-branch for v0.4.6 release

woop and others added 13 commits February 26, 2020 13:33
(cherry picked from commit 65f2ad7)
(cherry picked from commit fb39c6c)
* Fail formatting check before tests execute

By default, the spotless Maven plugin binds its check goal to the verify
phase (late in the lifecycle, after integration tests). Because we
currently only run `mvn test` for CI, it doesn't proceed as far as
verify so missed formatting is not caught by CI.

This binds the check to an earlier phase, in between test-compile and
test, so that it will fail before `mvn test` but not disrupt your dev
workflow of compiling main and test sources as you work. This strikes a
good compromise on failing fast for code standards without being _too_
nagging.

For the complete lifecycle reference, see:
https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html

* Apply spotless formatting

(cherry picked from commit 6363540)
…ast-dev#490)

* Fix fastavro version used in feast to 0.22.9

* Print python packages version used when e2e test fails

(cherry picked from commit 7586da6)
…s to StatsD (feast-dev#486)

* Extend WriteMetricsTransform to write feature value stats to StatsD

* Apply mvn spotless

* Catch all exception not just StatsDClientException during init
Since there are other exception like UnknownHostException that can be thrown and we want to know such error. Also change the log level to error because so it's not normal for client to fail to be created"

* Change log level due to invalid feature set ref to error (previously warn)
On 2nd thought, this should constitute an error not a warning

* Apply maven spotless to metric transform codes

(cherry picked from commit 5508c92)
* Allow use of secure gRPC in Feast Python client.

* Add tests for secure gRPC in Python client.

(cherry picked from commit a576a53)
So that it is consistent with the actual unit of timing being measured
And recommended metric names in Prometheus https://prometheus.io/docs/practices/naming/#metric-names

(cherry picked from commit 5758d99)
@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidheryanto davidheryanto changed the title Backport from master to v0.4 for v0.4.6 release Backport commits from master to v0.4 for v0.4.6 release Feb 26, 2020
@davidheryanto davidheryanto changed the title Backport commits from master to v0.4 for v0.4.6 release Backport commits from master to v0.4 branch for v0.4.6 release Feb 26, 2020
@zhilingc zhilingc merged commit bc22fda into feast-dev:v0.4-branch Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants