Skip to content

chore: Fix publish, versions issue #4944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tchughesiv merged 1 commit into from
Jan 21, 2025
Merged

chore: Fix publish, versions issue #4944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions .github/workflows/publish_images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,23 +24,21 @@ on:
type: string

jobs:
get-version:
uses: ./.github/workflows/get_semantic_release_version.yml
with:
custom_version: ${{ github.event.inputs.custom_version }}
token: ${{ github.event.inputs.token }}

build-publish-docker-images:
if: github.repository == 'feast-dev/feast'
runs-on: ubuntu-latest
needs: [ get-version ]
strategy:
matrix:
component: [ feature-server, feature-server-java, feature-transformation-server, feast-helm-operator, feast-operator ]
env:
MAVEN_CACHE: gs://feast-templocation-kf-feast/.m2.2020-08-19.tar
REGISTRY: feastdev
steps:
- id: get-version
uses: ./.github/workflows/get_semantic_release_version.yml
with:
custom_version: ${{ github.event.inputs.custom_version }}
token: ${{ github.event.inputs.token }}
- uses: actions/checkout@v4
- name: Set up QEMU
uses: docker/setup-qemu-action@v1
Expand All @@ -63,17 +61,14 @@ jobs:
run: gcloud info
- run: gcloud auth configure-docker --quiet
- name: Build image
env:
VERSION_WITHOUT_PREFIX: ${{ steps.get-version.outputs.version_without_prefix }}
run: |
make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${VERSION_WITHOUT_PREFIX}
env:
RELEASE_VERSION: ${{ needs.get-version.outputs.release_version }}
VERSION_WITHOUT_PREFIX: ${{ needs.get-version.outputs.version_without_prefix }}
HIGHEST_SEMVER_TAG: ${{ needs.get-version.outputs.highest_semver_tag }}
- name: Push versioned images
env:
RELEASE_VERSION: ${{ needs.get-version.outputs.release_version }}
VERSION_WITHOUT_PREFIX: ${{ needs.get-version.outputs.version_without_prefix }}
HIGHEST_SEMVER_TAG: ${{ needs.get-version.outputs.highest_semver_tag }}
VERSION_WITHOUT_PREFIX: ${{ steps.get-version.outputs.version_without_prefix }}
HIGHEST_SEMVER_TAG: ${{ steps.get-version.outputs.highest_semver_tag }}
run: |
make push-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${VERSION_WITHOUT_PREFIX}

Expand Down
Loading