Reduce refresh rate of specification refresh in Serving to 10 seconds#481
Merged
feast-ci-bot merged 1 commit intofeast-dev:masterfrom Feb 20, 2020
Merged
Reduce refresh rate of specification refresh in Serving to 10 seconds#481feast-ci-bot merged 1 commit intofeast-dev:masterfrom
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
davidheryanto
pushed a commit
to davidheryanto/feast
that referenced
this pull request
Feb 26, 2020
…feast-dev#481) (cherry picked from commit 887f9e3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces the amount of time Feast Serving waits before refreshing its cache of feature specifications from Feast Core. Ideally this would be configurable, but as a quick PR this reduces cache misses.