Skip to content

chore: Update packages and fix lint issues #4790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 5 commits into from
Nov 26, 2024
Merged

chore: Update packages and fix lint issues #4790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1490041
chore: Updated testcontainers to support MilvusContainer
franciscojavierarceo Nov 25, 2024
d42d5aa
downgraded
franciscojavierarceo Nov 25, 2024
36299cd
updating libraries to downgrade singlestore to 1.7.2
franciscojavierarceo Nov 26, 2024
1067b11
fixing lint issues post package upgrades
franciscojavierarceo Nov 26, 2024
c56390c
downgraded pyarrow
franciscojavierarceo Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/python/feast/driver_test_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
import itertools
from datetime import timedelta, timezone
from enum import Enum
from zoneinfo import ZoneInfo

import numpy as np
import pandas as pd
from zoneinfo import ZoneInfo

from feast.infra.offline_stores.offline_utils import (
DEFAULT_ENTITY_DF_EVENT_TIMESTAMP_COL,
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ class JWTAuthModel(FeastConfigBaseModel):


class CertificateAuthModel(FeastConfigBaseModel):
cert: FilePath = Field(default=None, alias="cert-file")
key: FilePath = Field(default=None, alias="key-file")
cert: Optional[FilePath] = Field(default=None, alias="cert-file")
key: Optional[FilePath] = Field(default=None, alias="key-file")


CLASSES_BY_AUTH_TYPE = {
Expand Down
7 changes: 4 additions & 3 deletions sdk/python/feast/registry_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,9 +792,10 @@ def start_server(
reflection.enable_server_reflection(service_names_available_for_reflection, server)

if tls_cert_path and tls_key_path:
with open(tls_cert_path, "rb") as cert_file, open(
tls_key_path, "rb"
) as key_file:
with (
open(tls_cert_path, "rb") as cert_file,
open(tls_key_path, "rb") as key_file,
):
certificate_chain = cert_file.read()
private_key = key_file.read()
server_credentials = grpc.ssl_server_credentials(
Expand Down
Loading
Loading