Skip to content

feat!: Refactor online stores by removing the contrib directory. (Breaking imports) #4731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 7 commits into from
Nov 7, 2024
Merged

feat!: Refactor online stores by removing the contrib directory. (Breaking imports) #4731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0d569be
feat: Refactor online store by removing the contrib directory
HaoXuAI Nov 2, 2024
1d6c312
feat: Refactor online store by removing the contrib directory
HaoXuAI Nov 2, 2024
24fd7de
feat: Refactor online store by removing the contrib directory
HaoXuAI Nov 2, 2024
13620e8
feat: Refactor online store by removing the contrib directory
HaoXuAI Nov 2, 2024
537cdd7
fix legacy mapping
HaoXuAI Nov 4, 2024
568dea0
fix legacy mapping
HaoXuAI Nov 4, 2024
4dc93c5
fix conflict
HaoXuAI Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ test-python-universal-postgres-offline:

test-python-universal-postgres-online:
PYTHONPATH='.' \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.postgres_repo_configuration \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.postgres_online_store.postgres_repo_configuration \
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.postgres \
python -m pytest -n 8 --integration \
-k "not test_universal_cli and \
Expand All @@ -242,7 +242,7 @@ test-python-universal-postgres-online:

test-python-universal-pgvector-online:
PYTHONPATH='.' \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.pgvector_repo_configuration \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.pgvector_repo_configuration \
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.postgres \
python -m pytest -n 8 --integration \
-k "not test_universal_cli and \
Expand All @@ -261,7 +261,7 @@ test-python-universal-postgres-online:

test-python-universal-mysql-online:
PYTHONPATH='.' \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.mysql_repo_configuration \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.mysql_online_store.mysql_repo_configuration \
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.mysql \
python -m pytest -n 8 --integration \
-k "not test_universal_cli and \
Expand All @@ -280,14 +280,14 @@ test-python-universal-postgres-online:

test-python-universal-cassandra:
PYTHONPATH='.' \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.cassandra_repo_configuration \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.cassandra_online_store.cassandra_repo_configuration \
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.cassandra \
python -m pytest -x --integration \
sdk/python/tests

test-python-universal-hazelcast:
PYTHONPATH='.' \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.hazelcast_repo_configuration \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.hazelcast_online_store.hazelcast_repo_configuration \
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.hazelcast \
python -m pytest -n 8 --integration \
-k "not test_universal_cli and \
Expand All @@ -306,7 +306,7 @@ test-python-universal-hazelcast:

test-python-universal-cassandra-no-cloud-providers:
PYTHONPATH='.' \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.cassandra_repo_configuration \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.cassandra_online_store.cassandra_repo_configuration \
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.cassandra \
python -m pytest -x --integration \
-k "not test_lambda_materialization_consistency and \
Expand All @@ -323,7 +323,7 @@ test-python-universal-cassandra-no-cloud-providers:

test-python-universal-elasticsearch-online:
PYTHONPATH='.' \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.elasticsearch_repo_configuration \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.elasticsearch_online_store.elasticsearch_repo_configuration \
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.elasticsearch \
python -m pytest -n 8 --integration \
-k "not test_universal_cli and \
Expand All @@ -342,7 +342,7 @@ test-python-universal-cassandra-no-cloud-providers:

test-python-universal-singlestore-online:
PYTHONPATH='.' \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.singlestore_repo_configuration \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.singlestore_repo_configuration \
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.singlestore \
python -m pytest -n 8 --integration \
-k "not test_universal_cli and \
Expand All @@ -353,7 +353,7 @@ test-python-universal-singlestore-online:

test-python-universal-qdrant-online:
PYTHONPATH='.' \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.qdrant_repo_configuration \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.qdrant_online_store.qdrant_repo_configuration \
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.qdrant \
python -m pytest -n 8 --integration \
-k "test_retrieve_online_documents" \
Expand Down
14 changes: 7 additions & 7 deletions docs/SUMMARY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,13 @@
* [DynamoDB](reference/online-stores/dynamodb.md)
* [Bigtable](reference/online-stores/bigtable.md)
* [Remote](reference/online-stores/remote.md)
* [PostgreSQL (contrib)](reference/online-stores/postgres.md)
* [Cassandra + Astra DB (contrib)](reference/online-stores/cassandra.md)
* [Couchbase (contrib)](reference/online-stores/couchbase.md)
* [MySQL (contrib)](reference/online-stores/mysql.md)
* [Hazelcast (contrib)](reference/online-stores/hazelcast.md)
* [ScyllaDB (contrib)](reference/online-stores/scylladb.md)
* [SingleStore (contrib)](reference/online-stores/singlestore.md)
* [PostgreSQL](reference/online-stores/postgres.md)
* [Cassandra + Astra DB](reference/online-stores/cassandra.md)
* [Couchbase](reference/online-stores/couchbase.md)
* [MySQL](reference/online-stores/mysql.md)
* [Hazelcast](reference/online-stores/hazelcast.md)
* [ScyllaDB](reference/online-stores/scylladb.md)
* [SingleStore](reference/online-stores/singlestore.md)
* [Registries](reference/registries/README.md)
* [Local](reference/registries/local.md)
* [S3](reference/registries/s3.md)
Expand Down
2 changes: 1 addition & 1 deletion docs/how-to-guides/customizing-feast/adding-support-for-a-new-online-store.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ class RedisOnlineStoreCreator(OnlineStoreCreator):
```Makefile
test-python-universal-cassandra:
PYTHONPATH='.' \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.cassandra_repo_configuration \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.cassandra_online_store.cassandra_repo_configuration \
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.cassandra \
IS_TEST=True \
python -m pytest -x --integration \
Expand Down
4 changes: 2 additions & 2 deletions docs/reference/online-stores/cassandra.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Cassandra + Astra DB online store (contrib)
# Cassandra + Astra DB online store

## Description

Expand Down Expand Up @@ -59,7 +59,7 @@ online_store:
```
{% endcode %}

The full set of configuration options is available in [CassandraOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.contrib.cassandra_online_store.cassandra_online_store.CassandraOnlineStoreConfig).
The full set of configuration options is available in [CassandraOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.cassandra_online_store.cassandra_online_store.CassandraOnlineStoreConfig).
For a full explanation of configuration options please look at file
`sdk/python/feast/infra/online_stores/contrib/cassandra_online_store/README.md`.

Expand Down
4 changes: 2 additions & 2 deletions docs/reference/online-stores/elasticsearch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ElasticSearch online store (contrib)
# ElasticSearch online store

## Description

Expand Down Expand Up @@ -26,7 +26,7 @@ online_store:
```
{% endcode %}

The full set of configuration options is available in [ElasticsearchOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.contrib.elasticsearch.ElasticsearchOnlineStoreConfig).
The full set of configuration options is available in [ElasticsearchOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.elasticsearch_online_store.ElasticsearchOnlineStoreConfig).

## Functionality Matrix

Expand Down
4 changes: 2 additions & 2 deletions docs/reference/online-stores/mysql.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# MySQL online store (contrib)
# MySQL online store

## Description

Expand Down Expand Up @@ -26,7 +26,7 @@ online_store:
```
{% endcode %}

The full set of configuration options is available in [MySQLOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.contrib.mysql.MySQLOnlineStoreConfig).
The full set of configuration options is available in [MySQLOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.mysql_online_store.MySQLOnlineStoreConfig).

## Functionality Matrix

Expand Down
6 changes: 3 additions & 3 deletions docs/reference/online-stores/postgres.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# PostgreSQL online store (contrib)
# PostgreSQL online store

## Description

Expand Down Expand Up @@ -35,7 +35,7 @@ online_store:
```
{% endcode %}

The full set of configuration options is available in [PostgreSQLOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.contrib.postgres.PostgreSQLOnlineStoreConfig).
The full set of configuration options is available in [PostgreSQLOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.postgres_online_store.PostgreSQLOnlineStoreConfig).

## Functionality Matrix

Expand Down Expand Up @@ -79,7 +79,7 @@ For the Retrieval Augmented Generation (RAG) use-case, you have to embed the qu
{% code title="python" %}
```python
from feast import FeatureStore
from feast.infra.online_stores.postgres import retrieve_online_documents
from feast.infra.online_stores.postgres_online_store import retrieve_online_documents

feature_store = FeatureStore(repo_path=".")

Expand Down
4 changes: 2 additions & 2 deletions docs/reference/online-stores/qdrant.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Qdrant online store (contrib)
# Qdrant online store

## Description

Expand Down Expand Up @@ -26,7 +26,7 @@ online_store:

{% endcode %}

The full set of configuration options is available in [QdrantOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.contrib.qdrant.QdrantOnlineStoreConfig).
The full set of configuration options is available in [QdrantOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.qdrant_online_store.QdrantOnlineStoreConfig).

## Functionality Matrix

Expand Down
2 changes: 1 addition & 1 deletion docs/reference/online-stores/scylladb.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ online_store:
{% endcode %}


The full set of configuration options is available in [CassandraOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.contrib.cassandra_online_store.cassandra_online_store.CassandraOnlineStoreConfig).
The full set of configuration options is available in [CassandraOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.cassandra_online_store.cassandra_online_store.CassandraOnlineStoreConfig).
For a full explanation of configuration options please look at file
`sdk/python/feast/infra/online_stores/contrib/cassandra_online_store/README.md`.

Expand Down
2 changes: 1 addition & 1 deletion docs/reference/online-stores/singlestore.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SingleStore online store (contrib)
# SingleStore online store

## Description

Expand Down
12 changes: 6 additions & 6 deletions sdk/python/docs/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,28 +359,28 @@ Snowflake Online Store
PostgreSQL Online Store
-----------------------

.. autoclass:: feast.infra.online_stores.contrib.postgres.PostgreSQLOnlineStore
.. autoclass:: feast.infra.online_stores.postgres_online_store.PostgreSQLOnlineStore
:members:

.. autoclass:: feast.infra.online_stores.contrib.postgres.PostgreSQLOnlineStoreConfig
.. autoclass:: feast.infra.online_stores.postgres_online_store.PostgreSQLOnlineStoreConfig
:members:

HBase Online Store
-----------------------

.. autoclass:: feast.infra.online_stores.contrib.hbase_online_store.hbase.HbaseOnlineStore
.. autoclass:: feast.infra.online_stores.hbase_online_store.hbase.HbaseOnlineStore
:members:

.. autoclass:: feast.infra.online_stores.contrib.hbase_online_store.hbase.HbaseOnlineStoreConfig
.. autoclass:: feast.infra.online_stores.hbase_online_store.hbase.HbaseOnlineStoreConfig
:members:

Cassandra Online Store
-----------------------

.. autoclass:: feast.infra.online_stores.contrib.cassandra_online_store.cassandra_online_store.CassandraOnlineStore
.. autoclass:: feast.infra.online_stores.cassandra_online_store.cassandra_online_store.CassandraOnlineStore
:members:

.. autoclass:: feast.infra.online_stores.contrib.cassandra_online_store.cassandra_online_store.CassandraOnlineStoreConfig
.. autoclass:: feast.infra.online_stores.cassandra_online_store.cassandra_online_store.CassandraOnlineStoreConfig
:members:

Batch Materialization Engine
Expand Down
4 changes: 2 additions & 2 deletions ...python/docs/source/feast.infra.online_stores.contrib.cassandra_online_store.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ Submodules
feast.infra.online\_stores.contrib.cassandra\_online\_store.cassandra\_online\_store module
-------------------------------------------------------------------------------------------

.. automodule:: feast.infra.online_stores.contrib.cassandra_online_store.cassandra_online_store
.. automodule:: feast.infra.online_stores.cassandra_online_store.cassandra_online_store
:members:
:undoc-members:
:show-inheritance:

Module contents
---------------

.. automodule:: feast.infra.online_stores.contrib.cassandra_online_store
.. automodule:: feast.infra.online_stores.cassandra_online_store
:members:
:undoc-members:
:show-inheritance:
4 changes: 2 additions & 2 deletions ...python/docs/source/feast.infra.online_stores.contrib.hazelcast_online_store.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ Submodules
feast.infra.online\_stores.contrib.hazelcast\_online\_store.hazelcast\_online\_store module
-------------------------------------------------------------------------------------------

.. automodule:: feast.infra.online_stores.contrib.hazelcast_online_store.hazelcast_online_store
.. automodule:: feast.infra.online_stores.hazelcast_online_store.hazelcast_online_store
:members:
:undoc-members:
:show-inheritance:

Module contents
---------------

.. automodule:: feast.infra.online_stores.contrib.hazelcast_online_store
.. automodule:: feast.infra.online_stores.hazelcast_online_store
:members:
:undoc-members:
:show-inheritance:
4 changes: 2 additions & 2 deletions sdk/python/docs/source/feast.infra.online_stores.contrib.hbase_online_store.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ Submodules
feast.infra.online\_stores.contrib.hbase\_online\_store.hbase module
--------------------------------------------------------------------

.. automodule:: feast.infra.online_stores.contrib.hbase_online_store.hbase
.. automodule:: feast.infra.online_stores.hbase_online_store.hbase
:members:
:undoc-members:
:show-inheritance:

Module contents
---------------

.. automodule:: feast.infra.online_stores.contrib.hbase_online_store
.. automodule:: feast.infra.online_stores.hbase_online_store
:members:
:undoc-members:
:show-inheritance:
4 changes: 2 additions & 2 deletions sdk/python/docs/source/feast.infra.online_stores.contrib.ikv_online_store.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ Submodules
feast.infra.online\_stores.contrib.ikv\_online\_store.ikv module
----------------------------------------------------------------

.. automodule:: feast.infra.online_stores.contrib.ikv_online_store.ikv
.. automodule:: feast.infra.online_stores.ikv_online_store.ikv
:members:
:undoc-members:
:show-inheritance:

Module contents
---------------

.. automodule:: feast.infra.online_stores.contrib.ikv_online_store
.. automodule:: feast.infra.online_stores.ikv_online_store
:members:
:undoc-members:
:show-inheritance:
4 changes: 2 additions & 2 deletions sdk/python/docs/source/feast.infra.online_stores.contrib.mysql_online_store.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ Submodules
feast.infra.online\_stores.contrib.mysql\_online\_store.mysql module
--------------------------------------------------------------------

.. automodule:: feast.infra.online_stores.contrib.mysql_online_store.mysql
.. automodule:: feast.infra.online_stores.mysql_online_store.mysql
:members:
:undoc-members:
:show-inheritance:

Module contents
---------------

.. automodule:: feast.infra.online_stores.contrib.mysql_online_store
.. automodule:: feast.infra.online_stores.mysql_online_store
:members:
:undoc-members:
:show-inheritance:
Loading
Loading