Skip to content

Use Java 8 SDK for branch 3.0 / 4.0 and Java 11 for master#473

Merged
feast-ci-bot merged 4 commits intofeast-dev:masterfrom
khorshuheng:prow-java-8
Feb 13, 2020
Merged

Use Java 8 SDK for branch 3.0 / 4.0 and Java 11 for master#473
feast-ci-bot merged 4 commits intofeast-dev:masterfrom
khorshuheng:prow-java-8

Conversation

@khorshuheng
Copy link
Copy Markdown
Collaborator

@khorshuheng khorshuheng commented Feb 13, 2020

Since #451, the master branch is using Java 11 SDK for prow. However, this result in test breaking on branch 4.0, which is not compatible with Java 11.

This PR will add Java 8 prow jobs exclusively for branch 4.0.

@woop
Copy link
Copy Markdown
Member

woop commented Feb 13, 2020

Just wondering about 0.3 (that the Agoda folks are still using). Should that be included here?

@khorshuheng khorshuheng changed the title Use Java 8 SDK for branch 4.0 and Java 11 for master Use Java 8 SDK for branch 3.0 / 4.0 and Java 11 for master Feb 13, 2020
@davidheryanto
Copy link
Copy Markdown
Collaborator

davidheryanto commented Feb 13, 2020 •
edited
Loading

I think for postsubmits jobs for both publish-java-8-sdk and publish-java-sdk we want them to run when a new release tag with syntax v[SEMANTIC_VERSION] ONLY, so we need to modify the branches filter a bit.

@khorshuheng khorshuheng force-pushed the prow-java-8 branch 3 times, most recently from fb0f0f2 to 78dddb7 Compare February 13, 2020 06:55
@davidheryanto
Copy link
Copy Markdown
Collaborator

davidheryanto commented Feb 13, 2020

/lgtm

@feast-ci-bot feast-ci-bot removed the lgtm label Feb 13, 2020
@davidheryanto
Copy link
Copy Markdown
Collaborator

davidheryanto commented Feb 13, 2020

/lgtm

@davidheryanto
Copy link
Copy Markdown
Collaborator

davidheryanto commented Feb 13, 2020

/approve

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Feb 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto, khorshuheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 1771532 into feast-dev:master Feb 13, 2020
@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Feb 13, 2020

@khorshuheng: Updated the config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file .prow/config.yaml
Details

In response to this:

Since #451, the master branch is using Java 11 SDK for prow. However, this result in test breaking on branch 4.0, which is not compatible with Java 11.

This PR will add Java 8 prow jobs exclusively for branch 4.0.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ches ches mentioned this pull request Mar 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidheryanto davidheryanto Awaiting requested review from davidheryanto

@pradithya pradithya Awaiting requested review from pradithya

@woop woop Awaiting requested review from woop

@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@davidheryanto davidheryanto

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@khorshuheng @woop @davidheryanto @feast-ci-bot