Skip to content

fix: Feast create empty online table when FeatureView attribute online=False #4666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lokeshrangineni merged 1 commit into from
Oct 28, 2024
Merged

fix: Feast create empty online table when FeatureView attribute online=False #4666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion sdk/python/feast/infra/passthrough_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,16 @@ def update_infra(
):
# Call update only if there is an online store
if self.online_store:
tables_to_keep_online = [
fv
for fv in tables_to_keep
if not hasattr(fv, "online") or (hasattr(fv, "online") and fv.online)
]

self.online_store.update(
config=self.repo_config,
tables_to_delete=tables_to_delete,
tables_to_keep=tables_to_keep,
tables_to_keep=tables_to_keep_online,
entities_to_keep=entities_to_keep,
entities_to_delete=entities_to_delete,
partial=partial,
Expand Down