Use concrete class in Java SDK Row for AvroCoder compatibility#465
Merged
feast-ci-bot merged 1 commit intofeast-dev:masterfrom Feb 7, 2020
Merged
Use concrete class in Java SDK Row for AvroCoder compatibility#465feast-ci-bot merged 1 commit intofeast-dev:masterfrom
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
Conversation
zhilingc
requested review from
davidheryanto,
khorshuheng,
pradithya and
woop
as code owners
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/retest |
khorshuheng
pushed a commit
to khorshuheng/feast
that referenced
this pull request
Feb 14, 2020
Merged
khorshuheng
pushed a commit
that referenced
this pull request
Feb 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I want to be able to use AvroCoder with the Java SDK Row type, but since Row fields are defined as
java.util.Mapthe AvroCoder is unable to encode objects containing theRowobject. Since we already always instantiate a HashMap, declaringfieldsto be a HashMap should be fine.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: