Skip to content

perf: Default to async endpoints, use threadpool for sync #4647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 7 commits into from
Oct 18, 2024
Merged

perf: Default to async endpoints, use threadpool for sync #4647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6ca3b47
add init and cleanup of long lived resources
robhowley Oct 17, 2024
43fda46
Merge branch 'feast-dev:master' into master
robhowley Oct 17, 2024
46147c2
offline store init doesnt make sense
robhowley Oct 17, 2024
3077696
Merge branch 'feast-dev:master' into master
robhowley Oct 18, 2024
ddab944
add explicit async support tags, use in server
robhowley Oct 18, 2024
b7370fd
remove offline store async supported property
robhowley Oct 18, 2024
55626f9
remove more offline refs
robhowley Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions sdk/python/feast/feature_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import psutil
from dateutil import parser
from fastapi import Depends, FastAPI, Request, Response, status
from fastapi.concurrency import run_in_threadpool
from fastapi.logger import logger
from fastapi.responses import JSONResponse
from google.protobuf.json_format import MessageToDict
Expand Down Expand Up @@ -112,7 +113,7 @@ async def get_body(request: Request):
"/get-online-features",
dependencies=[Depends(inject_user_details)],
)
def get_online_features(body=Depends(get_body)):
async def get_online_features(body=Depends(get_body)):
Copy link
Contributor Author

@robhowley robhowley Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/get-online-features endpoint is now async

body = json.loads(body)
full_feature_names = body.get("full_feature_names", False)
entity_rows = body["entities"]
Expand Down Expand Up @@ -145,15 +146,22 @@ def get_online_features(body=Depends(get_body)):
resource=od_feature_view, actions=[AuthzedAction.READ_ONLINE]
)

response_proto = store.get_online_features(
read_params = dict(
features=features,
entity_rows=entity_rows,
full_feature_names=full_feature_names,
).proto
)

if store._get_provider().async_supported.online.read:
response = await store.get_online_features_async(**read_params)
else:
response = await run_in_threadpool(
lambda: store.get_online_features(**read_params)
)
Comment on lines +155 to +160
Copy link
Contributor Author

@robhowley robhowley Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use async feature lookups if it's supported by the online store, otherwise run the sync method in the threadpool


# Convert the Protobuf object to JSON and return it
return MessageToDict(
response_proto, preserving_proto_field_name=True, float_precision=18
response.proto, preserving_proto_field_name=True, float_precision=18
)

@app.post("/push", dependencies=[Depends(inject_user_details)])
Expand Down
5 changes: 5 additions & 0 deletions sdk/python/feast/infra/online_stores/dynamodb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
from feast.infra.infra_object import DYNAMODB_INFRA_OBJECT_CLASS_TYPE, InfraObject
from feast.infra.online_stores.helpers import compute_entity_id
from feast.infra.online_stores.online_store import OnlineStore
from feast.infra.supported_async_methods import SupportedAsyncMethods
from feast.protos.feast.core.DynamoDBTable_pb2 import (
DynamoDBTable as DynamoDBTableProto,
)
Expand Down Expand Up @@ -88,6 +89,10 @@ class DynamoDBOnlineStore(OnlineStore):
_dynamodb_resource = None
_aioboto_session = None

@property
def async_supported(self) -> SupportedAsyncMethods:
return SupportedAsyncMethods(read=True)
Comment on lines +92 to +94
Copy link
Contributor Author

@robhowley robhowley Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an online store can opt in to using async read/write calls as they become available.


def update(
self,
config: RepoConfig,
Expand Down
5 changes: 5 additions & 0 deletions sdk/python/feast/infra/online_stores/online_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
from feast.feature_view import FeatureView
from feast.infra.infra_object import InfraObject
from feast.infra.registry.base_registry import BaseRegistry
from feast.infra.supported_async_methods import SupportedAsyncMethods
from feast.online_response import OnlineResponse
from feast.protos.feast.core.Registry_pb2 import Registry as RegistryProto
from feast.protos.feast.types.EntityKey_pb2 import EntityKey as EntityKeyProto
Expand All @@ -36,6 +37,10 @@ class OnlineStore(ABC):
The interface that Feast uses to interact with the storage system that handles online features.
"""

@property
def async_supported(self) -> SupportedAsyncMethods:
return SupportedAsyncMethods()
Comment on lines +40 to +42
Copy link
Contributor Author

@robhowley robhowley Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default an online store does not have async methods.


@abstractmethod
def online_write_batch(
self,
Expand Down
7 changes: 7 additions & 0 deletions sdk/python/feast/infra/passthrough_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
from feast.infra.online_stores.helpers import get_online_store_from_config
from feast.infra.provider import Provider
from feast.infra.registry.base_registry import BaseRegistry
from feast.infra.supported_async_methods import ProviderAsyncMethods
from feast.online_response import OnlineResponse
from feast.protos.feast.core.Registry_pb2 import Registry as RegistryProto
from feast.protos.feast.types.EntityKey_pb2 import EntityKey as EntityKeyProto
Expand Down Expand Up @@ -79,6 +80,12 @@ def offline_store(self):
)
return self._offline_store

@property
def async_supported(self) -> ProviderAsyncMethods:
return ProviderAsyncMethods(
online=self.online_store.async_supported,
)

@property
def batch_engine(self) -> BatchMaterializationEngine:
if self._batch_engine:
Expand Down
5 changes: 5 additions & 0 deletions sdk/python/feast/infra/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
from feast.infra.infra_object import Infra
from feast.infra.offline_stores.offline_store import RetrievalJob
from feast.infra.registry.base_registry import BaseRegistry
from feast.infra.supported_async_methods import ProviderAsyncMethods
from feast.on_demand_feature_view import OnDemandFeatureView
from feast.online_response import OnlineResponse
from feast.protos.feast.core.Registry_pb2 import Registry as RegistryProto
Expand Down Expand Up @@ -55,6 +56,10 @@ class Provider(ABC):
def __init__(self, config: RepoConfig):
pass

@property
def async_supported(self) -> ProviderAsyncMethods:
return ProviderAsyncMethods()

@abstractmethod
def update_infra(
self,
Expand Down
10 changes: 10 additions & 0 deletions sdk/python/feast/infra/supported_async_methods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
from pydantic import BaseModel, Field


class SupportedAsyncMethods(BaseModel):
read: bool = Field(default=False)
write: bool = Field(default=False)


class ProviderAsyncMethods(BaseModel):
online: SupportedAsyncMethods = Field(default_factory=SupportedAsyncMethods)