Skip to content

chore: Updated snowflake test to be more explicit about post apply entity_columns return value #4603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 1 commit into from
Oct 5, 2024
Merged

chore: Updated snowflake test to be more explicit about post apply entity_columns return value #4603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sdk/python/tests/integration/materialization/test_snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

from feast import Field
from feast.entity import Entity
from feast.feature_view import FeatureView
from feast.feature_view import DUMMY_ENTITY_FIELD, FeatureView
from feast.types import Array, Bool, Bytes, Float64, Int32, Int64, String, UnixTimestamp
from feast.utils import _utc_now
from tests.data.data_creator import create_basic_driver_dataset
Expand Down Expand Up @@ -189,7 +189,7 @@ def test_snowflake_materialization_consistency_internal_with_lists(
snowflake_environment.data_source_creator.teardown()


@pytest.mark.integration
# @pytest.mark.integration
def test_snowflake_materialization_entityless_fv():
snowflake_config = IntegrationTestRepoConfig(
online_store=SNOWFLAKE_ONLINE_CONFIG,
Expand Down Expand Up @@ -225,7 +225,7 @@ def test_snowflake_materialization_entityless_fv():

try:
fs.apply([overall_stats_fv, driver])
assert overall_stats_fv.entity_columns != []
assert overall_stats_fv.entity_columns == [DUMMY_ENTITY_FIELD]

# materialization is run in two steps and
# we use timestamp from generated dataframe as a split point
Expand Down