Allow use of secure gRPC in Feast Python client.#459
Allow use of secure gRPC in Feast Python client.#459feast-ci-bot merged 3 commits intofeast-dev:masterfrom
Conversation
Yanson
requested review from
davidheryanto,
khorshuheng,
pradithya,
woop and
zhilingc
as code owners
|
Hi @Yanson. Thanks for your PR. I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @davidheryanto |
|
Thanks for this @Yanson! Will try to have this reviewed soon. |
|
/ok-to-test |
|
@Yanson this PR looks good, but I think you will need to implement tests so that we know we aren't regressing in the future. Currently this is untested. |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Yanson, zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/lgtm |
* Allow use of secure gRPC in Feast Python client. * Add tests for secure gRPC in Python client. (cherry picked from commit a576a53)
* Allow use of secure gRPC in Feast Python client. * Add tests for secure gRPC in Python client. (cherry picked from commit a576a53)
5 participants
What this PR does / why we need it:
Since #458 enables provisioning of an nginx ingress with TLS, when connecting from outside the cluster, secure gRPC is required.
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: