Skip to content

feat: Adding registry cache support for get_on_demand_feature_view #4572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 1 commit into from
Sep 25, 2024
Merged

feat: Adding registry cache support for get_on_demand_feature_view #4572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,20 +492,24 @@ def _get_stream_feature_view(
stream_feature_view.entities = []
return stream_feature_view

def get_on_demand_feature_view(self, name: str) -> OnDemandFeatureView:
def get_on_demand_feature_view(
self, name: str, allow_registry_cache: bool = False
) -> OnDemandFeatureView:
"""
Retrieves a feature view.

Args:
name: Name of feature view.

allow_registry_cache: (Optional) Whether to allow returning this entity from a cached registry
Returns:
The specified feature view.

Raises:
FeatureViewNotFoundException: The feature view could not be found.
"""
return self._registry.get_on_demand_feature_view(name, self.project)
return self._registry.get_on_demand_feature_view(
name, self.project, allow_cache=allow_registry_cache
)

def get_data_source(self, name: str) -> DataSource:
"""
Expand Down