feat: Commit generated python proto files - #4546
Conversation
Signed-off-by: tokoko <togurgenidze@gmail.com>
Signed-off-by: tokoko <togurgenidze@gmail.com>
522f4c6 to
04b92c1
Compare
franciscojavierarceo
left a comment
franciscojavierarceo
left a comment
There was a problem hiding this comment.
This is a big one
Signed-off-by: tokoko <togurgenidze@gmail.com>
|
Support ends for 4.25.* by end of 2025 Q1. https://protobuf.dev/support/version-support/#python Conda now has 5.* version packages. https://github.com/conda-forge/protobuf-feedstock/pulls?q=is%3Apr+is%3Aclosed https://anaconda.org/conda-forge/protobuf/files Can we try with Version 5 now and see what happens now? We may need lock Protobuf dependency to a version which conda supports. We can do that in a next PR. So we get benefits of Protobuf v5. |
|
@EXPEbdodla That's a perfect timing 😆 I'd still prefer to defer it to another PR, because we might have that runtime version warning problem to solve somehow with protobuf 5. |
| # Protos | ||
| sdk/python/docs/html | ||
| sdk/python/feast/protos/ | ||
| sdk/go/protos/ |
There was a problem hiding this comment.
Can probably removes all of the protos from the git ignore, yeah?
There was a problem hiding this comment.
I think those are golang ones, I'll look into it later, don't want to push something extra inadvertently.
franciscojavierarceo
left a comment
franciscojavierarceo
left a comment
There was a problem hiding this comment.
Think we can update the git ignore to remove all references to protos but this lgtm
|
Merged, let's see what this buys us 😆 we can always revert back... |
|
Can you change the PR Title to feature instead of chore? Want to make sure it's included loudly in the release notes 👍 |
tokoko
changed the title
* chore: commit generated python files to repo Signed-off-by: tokoko <togurgenidze@gmail.com> * merge from master Signed-off-by: tokoko <togurgenidze@gmail.com> * chore: remove protos from gitignore Signed-off-by: tokoko <togurgenidze@gmail.com> --------- Signed-off-by: tokoko <togurgenidze@gmail.com>
3 participants
What this PR does / why we need it:
Fixes #4541