Skip to content

Conversation

@dmartinol
Copy link
Contributor

@dmartinol dmartinol commented Sep 17, 2024

What this PR does / why we need it:

Provide a reference implementation of Feast project installed on local Kind cluster and validated with a remote client.

  • Prerequisites are mentioned and reference installation commands provided for MacOS.
  • A postgres template is used to initialize the project.
  • All the commands are executed from individual notebooks, which also report the output of the latest run.
  • Hints are provided to customize the provided code for a personalized experience.
  • A dedicated Job is used to apply the feature store definitions (e.g. feast apply) and materializations, overcoming issues: Remote materialization #4526 and Remote apply #4529

Note: the execution of the client application is still affected by #4392 until we release the new version

Which issue(s) this PR fixes:

Fixes #4527

Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol
Copy link
Contributor Author

@dmartinol dmartinol mentioned this pull request Sep 17, 2024
@lokeshrangineni
Copy link
Contributor

lokeshrangineni commented Sep 17, 2024

A brief readme.md description about the example at https://github.com/dmartinol/feast/tree/install_kind/examples/kind-quickstart will help before looking at all the jupyter notebooks and figure it out. something similar to this PR description or section in pre-req.

Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol
Copy link
Contributor Author

A brief readme.md description about the example at https://github.com/dmartinol/feast/tree/install_kind/examples/kind-quickstart will help before looking at all the jupyter notebooks and figure it out. something similar to this PR description or section in pre-req.

Thanks for noticing, it reained untracked in my local repo 😲

dmartinol and others added 2 commits September 18, 2024 08:44
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol
Copy link
Contributor Author

@franciscojavierarceo could pls you TAL?

"cell_type": "markdown",
"metadata": {},
"source": [
"Note If you see the following error, it is likely due to the [issue #4392](https://github.com/feast-dev/feast/issues/4392):\n",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're showing this error on purpose then, eh?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the issue has been fixed after this PR, I should have updated it.

Copy link
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@franciscojavierarceo franciscojavierarceo merged commit e675cbd into feast-dev:master Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add example of deployment of Feast in local Kubernetes environment

4 participants