Update Python SDK so FeatureSet can import Schema from Tensorflow metadata#450
Merged
feast-ci-bot merged 12 commits intofeast-dev:masterfrom Apr 10, 2020
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidheryanto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
woop
reviewed
Jan 30, 2020
woop
reviewed
Jan 30, 2020
woop
reviewed
Jan 30, 2020
Member
|
Other than the above, it looks good as a first cut. |
Collaborator
Author
|
/hold |
7966a5d to
9a1f24a
Compare
Collaborator
Author
|
/hold cancel |
Member
|
@davidheryanto this PR contains the same code as #449 |
Collaborator
Author
|
Yes because the end to end tests were written in Python and it depends on the Python SDK, |
9439ea1 to
ffc26fc
Compare
woop
reviewed
Mar 9, 2020
woop
reviewed
Mar 9, 2020
woop
reviewed
Mar 9, 2020
woop
reviewed
Mar 9, 2020
- Update Field, Feature and Entity class with fields from presence_constraints, shape_type and domain_info
- Update documentation for properties in Field - Deduplication refactoring in FeatureSet
They are not necessary for now and to avoid unexpected breaking changes.
In import_tfx_schema method, the domain info is first made inline so there is no need to have schema level domain info when updating Feast Entity and Feature. Also added documentation to setter property methods in Field.py
283d52d to
6af74c6
Compare
Collaborator
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR extends
FeatureSet,EntityandFeatureclass in Python SDK so they can contain constraints defined in theSchemafrom Tensorflow metadata:https://github.com/tensorflow/metadata/blob/ddf582f66eeeddb862de6d53c3e03d6eed1c04a6/tensorflow_metadata/proto/v0/schema.proto
These contraints
presence_constraints,shape_typeanddomain_infocan be used for validation of feature values and presence in Feast. Typical usage when one is already using Tensorflow data validation is as follows:Which issue(s) this PR fixes:
Related to #172
Does this PR introduce a user-facing change?: