chore: Remove upper bound from fsspec requirement #4461
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In feast-dev#3922 the fsspec requirement was loosened to allow what was then more recent releases. Since then Feast has further reduced the number dependencies with upper bounds. Instead of re-testing each month (when fsspec usually releases) it would now be idiomatic only specify a minimum bound. The new minimum bound was chosen to match what was last locked in ci, since that is what was tested and we can be less sure older versions also work. Signed-off-by: Chris Burroughs <chris.burroughs@gmail.com>
Signed-off-by: Chris Burroughs <chris.burroughs@gmail.com>
Collaborator
|
No upper bound seems like trouble. Why doesn't fsspec do semver? Are there any breaking changes we need to be aware of? |
Contributor
Author
|
I am unable to find a broader discussion of why |
Collaborator
|
I'm honestly not sure about this. how about we simply bump the upper to latest for now? |
cburroughs
added a commit
to cburroughs/feast
that referenced
this pull request
Sep 11, 2024
cburroughs
added a commit
to cburroughs/feast
that referenced
this pull request
Sep 11, 2024
Alternative to feast-dev#4461 Signed-off-by: Chris Burroughs <chris.burroughs@gmail.com>
Contributor
Author
|
Closing in favor of #4512 then |
cburroughs
added a commit
to cburroughs/feast
that referenced
this pull request
Sep 12, 2024
Alternative to feast-dev#4461 Signed-off-by: Chris Burroughs <chris.burroughs@gmail.com>
tokoko
pushed a commit
that referenced
this pull request
Sep 16, 2024
Alternative to #4461 Signed-off-by: Chris Burroughs <chris.burroughs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3922 the fsspec requirement was loosened to allow what was then more recent releases. Since then Feast has further reduced the number dependencies with upper bounds. Instead of re-testing each month (when fsspec usually releases) it would now be idiomatic only specify a minimum bound.
The new minimum bound was chosen to match what was last locked in ci, since that is what was tested and we can be less sure older versions also work.