Skip to content

chore: Mark tests using keycloak with xdist_group #4436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tokoko merged 2 commits into from
Aug 25, 2024
Merged

chore: Mark tests using keycloak with xdist_group #4436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e16e64
mark keycloak tests with xdist_group
tokoko Aug 22, 2024
8362428
apply changes to test-python-integration
tokoko Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,14 +86,14 @@ test-python-unit:
python -m pytest -n 8 --color=yes sdk/python/tests

test-python-integration:
python -m pytest -n 4 --integration --color=yes --durations=10 --timeout=1200 --timeout_method=thread \
python -m pytest -n 8 --integration --color=yes --durations=10 --timeout=1200 --timeout_method=thread --dist loadgroup \
-k "(not snowflake or not test_historical_features_main)" \
sdk/python/tests

test-python-integration-local:
FEAST_IS_LOCAL_TEST=True \
FEAST_LOCAL_ONLINE_CONTAINER=True \
python -m pytest -n 4 --color=yes --integration --durations=10 --timeout=1200 --timeout_method=thread --dist loadgroup \
python -m pytest -n 8 --color=yes --integration --durations=10 --timeout=1200 --timeout_method=thread --dist loadgroup \
-k "not test_lambda_materialization and not test_snowflake_materialization" \
sdk/python/tests

Expand Down
6 changes: 5 additions & 1 deletion sdk/python/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,11 @@ def pytest_generate_tests(metafunc: pytest.Metafunc):
c = IntegrationTestRepoConfig(**config)

if c not in _config_cache:
_config_cache[c] = c
marks = [
pytest.mark.xdist_group(name=m)
for m in c.offline_store_creator.xdist_groups()
]
_config_cache[c] = pytest.param(c, marks=marks)

configs.append(_config_cache[c])
else:
Expand Down
3 changes: 3 additions & 0 deletions sdk/python/tests/integration/feature_repos/universal/data_source_creator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,6 @@ def create_logged_features_destination(self) -> LoggingDestination:
@abstractmethod
def teardown(self):
raise NotImplementedError

def xdist_groups() -> list[str]:
return []
3 changes: 3 additions & 0 deletions sdk/python/tests/integration/feature_repos/universal/data_sources/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,9 @@ def __init__(self, project_name: str, *args, **kwargs):
self.server_port: int = 0
self.proc = None

def xdist_groups() -> list[str]:
return ["keycloak"]

def setup(self, registry: RegistryConfig):
parent_offline_config = super().create_offline_store_config()
config = RepoConfig(
Expand Down