Skip to content

fix: Remove redundant batching in PostgreSQLOnlineStore.online_write_batch and fix progress bar #4331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 4 commits into from
Jul 8, 2024
Merged

fix: Remove redundant batching in PostgreSQLOnlineStore.online_write_batch and fix progress bar #4331

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a7350b
Remove batching and fix tqdm progress bar
TomSteenbergen Jul 4, 2024
13040cf
Comment
TomSteenbergen Jul 4, 2024
b0bb799
Remove test changes
TomSteenbergen Jul 4, 2024
24551f4
Update comment
TomSteenbergen Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions sdk/python/feast/infra/online_stores/contrib/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ def online_write_batch(
Tuple[EntityKeyProto, Dict[str, ValueProto], datetime, Optional[datetime]]
],
progress: Optional[Callable[[int], Any]],
batch_size: int = 5000,
) -> None:
# Format insert values
insert_values = []
Expand Down Expand Up @@ -118,15 +117,13 @@ def online_write_batch(
"""
).format(sql.Identifier(_table_id(config.project, table)))

# Push data in batches to online store
# Push data into the online store
with self._get_conn(config) as conn, conn.cursor() as cur:
for i in range(0, len(insert_values), batch_size):
cur_batch = insert_values[i : i + batch_size]
cur.executemany(sql_query, cur_batch)
conn.commit()
cur.executemany(sql_query, insert_values)
conn.commit()

if progress:
progress(len(cur_batch))
if progress:
progress(len(data))

def online_read(
self,
Expand Down