Parameterize end-to-end test scripts#433
Conversation
Yanson
requested review from
davidheryanto,
khorshuheng,
pradithya,
woop and
zhilingc
as code owners
|
Hi @Yanson. Thanks for your PR. I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @woop |
|
/ok-to-test |
|
/lgtm |
|
/approve |
|
Thanks for this @Yanson! Will merge it in. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, woop, Yanson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
What this PR does / why we need it:
Allow GCP project/bucket to be set in environment when running end-to-end tests. This is to allow us to run the e2e tests on our CI (Cloud Build) against our own GCP resources.
Additionally, 1/ allow skipping building of jars in e2e steps as we build them in a previous step, 2/ allow suffix to be specified to find jar as we use commit has rather than SNAPSHOT, 3/ print feast logs on test failure to help diagnosis.
This PR also aligns
test-end-to-end.shandtest-end-to-end-batch.shmuch more closely.Which issue(s) this PR fixes:
This does not fix anything. The motivation was to be able replicate the test failures in #431 .
Does this PR introduce a user-facing change?: