chore: Registry tests cleanup#4232
Merged
franciscojavierarceo merged 5 commits intoMay 29, 2024
Merged
Conversation
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
franciscojavierarceo
approved these changes
May 29, 2024
Member
|
Very nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
test_universal_registry.pyare pinned to a single worker usingxdist_groupto cut down on setup times as session-scoped fixtures aren't reused across workers.test_universal_cli.pywas unnecessarily marked withuniversal_offline_stores, changed to run only once withfileoffline store.test_apply_feature_view_integrationandtest_apply_entity_integrationtests intest_feature_store.pyare removed as there are basically identical totest_apply_feature_view_successandtest_apply_entity_successtests intest_universal_registry.py.test_remote.pywas removed as it was testing for only a small subset of functionality compared totest_universal_registry.py.mock_remote_registryfixture fromtest_remote.pywas instead moved totest_universal_registry.py. This was impossible before because universal registry tests depended onapply/deleteoperations as well.test_registry_server.pyis also effectively superseded bytest_universal_registry.pyas it's testing for a much wider range of functionality from a higher-level interface (remoteregistry instead of direct grpc server calls).P.S. In my dev environment the changes cut the overall runtime of
test-python-integration-localfrom ~7m down to ~4m.