chore: Refactor test environment setup #4210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
Collaborator
Author
|
cc @dmartinol |
Contributor
jeremyary
approved these changes
May 21, 2024
Collaborator
Author
|
Are you running linter on tests folder as well? mypy in |
Contributor
never mind, I missed to build the dev env, my fault sorry! |
franciscojavierarceo
pushed a commit
that referenced
this pull request
May 27, 2024
* refactor it test environment setup Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * fix test_offline_store env setup Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * fix it tests Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * fix it tests Signed-off-by: tokoko <togurg14@freeuni.edu.ge> --------- Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR refactors bunch of code around environment setup for integration tests.
IntegrationTestRepoConfigandEnvironmentclasses from one another. (Need to investigate if we can get rid of one of them entirely)setupmethod inDataSourceCreatorthat takes registry config as an input. This is necessary for remote DataSourceCreator as server-side feature store and client-side need to use the same registry in tests.