Skip to content

fix: Helm chart feast-feature-server, improve Service template name #4161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyary merged 1 commit into from
May 1, 2024
Merged

fix: Helm chart feast-feature-server, improve Service template name #4161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/python-helm-demo/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,11 @@ We use the Feast CLI to register and materialize features, and then retrieving v
3. `helm install feast-release ../../../infra/charts/feast-feature-server --set image.tag=dev --set feature_store_yaml_base64=$(base64 feature_store.yaml)`
5. (Optional): check logs of the server to make sure it’s working
```bash
kubectl logs svc/feast-feature-server
kubectl logs svc/feast-release-feast-feature-server
```
6. Port forward to expose the grpc endpoint:
```bash
kubectl port-forward svc/feast-feature-server 6566:80
kubectl port-forward svc/feast-release-feast-feature-server 6566:80
```
7. Run test fetches for online features:8.
- First: change back the Redis connection string to allow localhost connections to Redis
Expand Down
2 changes: 1 addition & 1 deletion infra/charts/feast-feature-server/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
kind: Service
metadata:
name: {{ include "feast-feature-server.name" . }}
name: {{ include "feast-feature-server.fullname" . }}
labels:
{{- include "feast-feature-server.labels" . | nindent 4 }}
spec:
Expand Down