Skip to content

fix: Make sure schema is used when calling get_table_query_string method for Snowflake datasource #4131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyary merged 2 commits into from
Apr 25, 2024
Merged

fix: Make sure schema is used when calling get_table_query_string method for Snowflake datasource #4131

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64848a2
Fix get_table_query_string method for Snowflake datasource
TomSteenbergen Apr 23, 2024
f6c7c65
Add quotes to table string
TomSteenbergen Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/python/feast/infra/offline_stores/snowflake_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,10 @@ def validate(self, config: RepoConfig):

def get_table_query_string(self) -> str:
"""Returns a string that can directly be used to reference this table in SQL."""
if self.database and self.table:
if self.database and self.schema and self.table:
return f'"{self.database}"."{self.schema}"."{self.table}"'
elif self.schema and self.table:
return f'"{self.schema}"."{self.table}"'
elif self.table:
return f'"{self.table}"'
else:
Expand Down