Skip to content

fix: Remove top-level grpc import in cli #4107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaoXuAI merged 1 commit into from
Apr 17, 2024
Merged

fix: Remove top-level grpc import in cli #4107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdk/python/feast/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
)
from feast.errors import FeastObjectNotFoundException, FeastProviderLoginError
from feast.feature_view import FeatureView
from feast.infra.contrib.grpc_server import get_grpc_server
from feast.on_demand_feature_view import OnDemandFeatureView
from feast.repo_config import load_repo_config
from feast.repo_operations import (
Expand Down Expand Up @@ -734,6 +733,8 @@ def listen_command(
registry_ttl_sec: int,
):
"""Start a gRPC feature server to ingest streaming features on given address"""
from feast.infra.contrib.grpc_server import get_grpc_server

store = create_feature_store(ctx)
server = get_grpc_server(address, store, max_workers, registry_ttl_sec)
server.start()
Expand Down