feat: Add tags to dynamodb config#4100
Merged
franciscojavierarceo merged 2 commits intoApr 17, 2024
Merged
Conversation
Signed-off-by: hkuepers <hanno.kuepers@ratepay.com>
Signed-off-by: hkuepers <hanno.kuepers@ratepay.com>
auto-merge was automatically disabled
April 16, 2024 14:56
Head branch was pushed to by a user without write access
Contributor
Author
|
The integration test failed due to an aws iam permission error. It seems that even when the I think this is not only an issue of the integration test but in general it would break existing setups. The permission to add tags should only be required if tags are actually configured in the config file for DynamoDB. I made a change that should avoid such an issue and add the |
franciscojavierarceo
approved these changes
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add the option to configure and set tags on the AWS DynamoDB table resource created for an online store. Many organizations use tags to manage their resources which makes it convenient to directly add tags in the configuration file of Feast so that they are added upon creation of the tables.
Which issue(s) this PR fixes:
Fixes