Skip to content

fix: Add __eq__, __hash__ to SparkSource for correct comparison #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaoXuAI merged 5 commits into from
Mar 26, 2024
Merged

fix: Add __eq__, __hash__ to SparkSource for correct comparison #4028

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f37e07
feat: Enable Arrow-based columnar data transfers
ElliotNguyen68 Mar 19, 2024
8eb0c59
Merge branch 'feast-dev:master' into master
ElliotNguyen68 Mar 21, 2024
c1c9990
fix: Add __eq__, __hash__ to SparkSource for comparision
ElliotNguyen68 Mar 21, 2024
add7f3a
chore: simplify the logic
ElliotNguyen68 Mar 21, 2024
6cba191
Merge branch 'feast-dev:master' into master
ElliotNguyen68 Mar 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,19 @@ def get_table_query_string(self) -> str:

return f"`{tmp_table_name}`"

def __eq__(self, other):
base_eq = super().__eq__(other)
if not base_eq:
return False
return (
self.table == other.table
and self.query == other.query
and self.path == other.path
)

def __hash__(self):
return super().__hash__()


class SparkOptions:
allowed_formats = [format.value for format in SparkSourceFormat]
Expand Down