Skip to content

fix: Using version args to install the correct feast version #3953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shuchu merged 2 commits into from
Feb 20, 2024
+11 −4
Merged

fix: Using version args to install the correct feast version #3953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ca7082
using version args to install the correct feast version
bushwhackr Feb 16, 2024
00f6bec
revert the COPY command
bushwhackr Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions sdk/python/feast/infra/feature_servers/multicloud/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
FROM python:3.8

# Input the feast version to install
# This requires feast package to be available in pypi before building this image
ARG VERSION

RUN apt update && \
apt install -y \
jq \
python3-dev \
build-essential

RUN pip install pip --upgrade
RUN pip install "feast[aws,gcp,snowflake,redis,go,mysql,postgres]"

RUN pip install "feast[aws,gcp,snowflake,redis,go,mysql,postgres]==${VERSION}"

RUN apt update
RUN apt install -y -V ca-certificates lsb-release wget
Expand Down
8 changes: 6 additions & 2 deletions sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
FROM python:3.8

# Input the feast version to install
# This requires feast package to be available in pypi before building this image
ARG VERSION

RUN apt update && \
apt install -y \
jq \
Expand All @@ -9,11 +13,11 @@ RUN apt update && \
RUN pip install pip --upgrade
COPY . .

RUN pip install "feast[aws,gcp,snowflake,redis,go,mysql,postgres]"
RUN pip install "feast[aws,gcp,snowflake,redis,go,mysql,postgres]==${VERSION}"

RUN apt update
RUN apt install -y -V ca-certificates lsb-release wget
RUN wget https://apache.jfrog.io/artifactory/arrow/$(lsb_release --id --short | tr 'A-Z' 'a-z')/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb
RUN apt install -y -V ./apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb
RUN apt update
RUN apt -y install libarrow-dev
RUN apt -y install libarrow-dev