chore: Set upper bound for moto package #3937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
sudohainguyen
changed the title
Collaborator
|
Lint failed |
Collaborator
Author
hmm I'm seeing all checks passed |
Collaborator
I'm seeing this one failed: https://github.com/feast-dev/feast/actions/runs/7809136271/job/21300448191#step:2:1, |
Collaborator
Author
yeah it is staled, already fixed 😄 |
Collaborator
yeah staled on my phone lol |
zseta
pushed a commit
to zseta/feast
that referenced
this pull request
Feb 7, 2024
chore: set upper bound for moto package Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com> Signed-off-by: Attila Toth <hello@attilatoth.dev>
tqtensor
pushed a commit
to tqtensor/feast
that referenced
this pull request
Mar 11, 2024
chore: set upper bound for moto package Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
motopackage just recently released version 5.0.0 with some breaking changes, which potentially break our integration tests, so that the upper bound for the package is neededWhich issue(s) this PR fixes:
N/A
Note: no need to re-compile requirements files since moto is still <5