Skip to content

Conversation

@sudohainguyen
Copy link
Collaborator

@sudohainguyen sudohainguyen commented Feb 4, 2024

What this PR does / why we need it:
Relax pandas upper bound to support v2.0

Which issue(s) this PR fixes:

Fixes #3709

Additional changes:

Set upper bound for moto due to its recent breaking changes in 5.0.0

@sudohainguyen sudohainguyen force-pushed the deps branch 3 times, most recently from 095047b to b321bfa Compare February 4, 2024 13:00
@sudohainguyen sudohainguyen requested a review from shuchu February 4, 2024 13:46
@sudohainguyen
Copy link
Collaborator Author

pending on #3925
cc: @franciscojavierarceo

@sudohainguyen
Copy link
Collaborator Author

seems the issue appears in integration tests related to this issue from pandas pandas-dev/pandas#55730

we need to pin pandas version to at least 2.1.3 in order to adopt pandas v2, however the library only supports python 3.8 till 2.0.3

@sudohainguyen
Copy link
Collaborator Author

Note: just run local integration tests successfully on python 3.10, pandas 2.2.0
however it's not possible to make python 3.8 + pandas 2 + feast work together, if users install py 3.8 with feast, they shall not use pandas v2

Copy link
Collaborator

@HaoXuAI HaoXuAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicee!

@sudohainguyen
Copy link
Collaborator Author

still err, hang on, working on it

@sudohainguyen sudohainguyen added the dependencies Pull requests that update a dependency file label Feb 11, 2024
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file ok-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pandas 2.0 support

3 participants