Skip to content

fix: Remove unnecessary dependency on mysqlclient #3925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 1 commit into from
Feb 4, 2024
Merged

fix: Remove unnecessary dependency on mysqlclient #3925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sdk/python/feast/infra/feature_servers/multicloud/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ RUN apt update && \
apt install -y \
jq \
python3-dev \
default-libmysqlclient-dev \
build-essential

RUN pip install pip --upgrade
Expand Down
1 change: 0 additions & 1 deletion sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ RUN apt update && \
apt install -y \
jq \
python3-dev \
default-libmysqlclient-dev \
build-essential

RUN pip install pip --upgrade
Expand Down
2 changes: 0 additions & 2 deletions sdk/python/requirements/py3.10-ci-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,8 +472,6 @@ mypy-extensions==1.0.0
# mypy
mypy-protobuf==3.1.0
# via feast (setup.py)
mysqlclient==2.2.0
# via feast (setup.py)
nbclient==0.9.0
# via nbconvert
nbconvert==7.11.0
Expand Down
2 changes: 0 additions & 2 deletions sdk/python/requirements/py3.8-ci-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,8 +488,6 @@ mypy-extensions==1.0.0
# mypy
mypy-protobuf==3.1.0
# via feast (setup.py)
mysqlclient==2.2.0
# via feast (setup.py)
nbclient==0.9.0
# via nbconvert
nbconvert==7.11.0
Expand Down
2 changes: 0 additions & 2 deletions sdk/python/requirements/py3.9-ci-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,8 +479,6 @@ mypy-extensions==1.0.0
# mypy
mypy-protobuf==3.1.0
# via feast (setup.py)
mysqlclient==2.2.0
# via feast (setup.py)
nbclient==0.9.0
# via nbconvert
nbconvert==7.11.0
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/unit/test_sql_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def mysql_registry():

registry_config = RegistryConfig(
registry_type="sql",
path=f"mysql+mysqldb://{POSTGRES_USER}:{POSTGRES_PASSWORD}@127.0.0.1:{container_port}/{POSTGRES_DB}",
path=f"mysql+pymysql://{POSTGRES_USER}:{POSTGRES_PASSWORD}@127.0.0.1:{container_port}/{POSTGRES_DB}",
)

yield SqlRegistry(registry_config, "project", None)
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
"psycopg2-binary>=2.8.3,<3",
]

MYSQL_REQUIRED = ["mysqlclient", "pymysql", "types-PyMySQL"]
MYSQL_REQUIRED = ["pymysql", "types-PyMySQL"]

HBASE_REQUIRED = [
"happybase>=1.2.0,<3",
Expand Down