chore: Loosen fsspec requirements to allow recent releases #3922
+510
−509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburroughs
commented
Jan 31, 2024
| "minio==7.1.0", | ||
| "mock==2.0.0", | ||
| "moto", | ||
| "moto<5", |
Contributor
Author
There was a problem hiding this comment.
5 changed around the api and current tests do not pass without modification.
Collaborator
There was a problem hiding this comment.
I also stumbled into this, any idea why CI isn't failing as well?
Contributor
Author
There was a problem hiding this comment.
I suspect that some transitive dependency was previously holding it back.
Collaborator
There was a problem hiding this comment.
Moto v5 just released last week though, that's why CI succeeded
cburroughs
force-pushed
the
csb/fsspec-loosen
branch
from
9f780a4 to
730e720
Compare
Collaborator
|
the last time we updated fsspec (from my commits), I got stuck when compiling by pyarrow deps. |
cburroughs
force-pushed
the
csb/fsspec-loosen
branch
2 times, most recently
from
3ed7e10 to
2a71a61
Compare
Contributor
Author
|
What does this PR need to move forward? |
Collaborator
|
Just wanted to do integration tests since this issue is related to dependencies. So closing this now? 🤔 |
(I'm not sure the project has a super consistent pattern for when to specify a maximum version, but was going for the smallest possible change.) Signed-off-by: Chris Burroughs <chris.burroughs@gmail.com>
Signed-off-by: Chris Burroughs <chris.burroughs@gmail.com>
cburroughs
force-pushed
the
csb/fsspec-loosen
branch
from
2a71a61 to
0786e44
Compare
Contributor
Author
|
cc @franciscojavierarceo per dev call |
Signed-off-by: Chris Burroughs <chris.burroughs@gmail.com>
cburroughs
force-pushed
the
csb/fsspec-loosen
branch
from
0786e44 to
d6e312f
Compare
tqtensor
pushed a commit
to tqtensor/feast
that referenced
this pull request
Mar 11, 2024
…#3922) * chore: Loosen fsspec requirements to allow recent releases (I'm not sure the project has a super consistent pattern for when to specify a maximum version, but was going for the smallest possible change.) Signed-off-by: Chris Burroughs <chris.burroughs@gmail.com> * drop redundant fsspec now that this is in another extra Signed-off-by: Chris Burroughs <chris.burroughs@gmail.com> * post rebase regen Signed-off-by: Chris Burroughs <chris.burroughs@gmail.com> --------- Signed-off-by: Chris Burroughs <chris.burroughs@gmail.com>
cburroughs
added a commit
to cburroughs/feast
that referenced
this pull request
Aug 28, 2024
In feast-dev#3922 the fsspec requirement was loosened to allow what was then more recent releases. Since then Feast has further reduced the number dependencies with upper bounds. Instead of re-testing each month (when fsspec usually releases) it would now be idiomatic only specify a minimum bound. The new minimum bound was chosen to match what was last locked in ci, since that is what was tested and we can be less sure older versions also work. Signed-off-by: Chris Burroughs <chris.burroughs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I'm not sure the project has a super consistent pattern for when to specify a maximum version, but was going for the smallest possible change.)