Skip to content

fix: Bytewax materialization engine fails when loading feature_store.yaml #3912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etirelli merged 2 commits into from
Jan 30, 2024
Merged

fix: Bytewax materialization engine fails when loading feature_store.yaml #3912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9008f1
bytewax materialization loads yaml config correctly
marti-jorda-roca Jan 29, 2024
b4420a3
added postgres dependency for SQL registries
marti-jorda-roca Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/materialization/contrib/bytewax/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ COPY README.md README.md
# git dir to infer the version of feast we're installing.
# https://github.com/pypa/setuptools_scm#usage-from-docker
# I think it also assumes that this dockerfile is being built from the root of the directory.
RUN --mount=source=.git,target=.git,type=bind pip3 install --no-cache-dir '.[aws,gcp,bytewax,snowflake]'
RUN --mount=source=.git,target=.git,type=bind pip3 install --no-cache-dir '.[aws,gcp,bytewax,snowflake,postgres]'

4 changes: 2 additions & 2 deletions sdk/python/feast/infra/materialization/contrib/bytewax/dataflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
logging.basicConfig(level=logging.INFO)

with open("/var/feast/feature_store.yaml") as f:
feast_config = yaml.safe_load(f)
feast_config = yaml.load(f, Loader=yaml.Loader)

with open("/var/feast/bytewax_materialization_config.yaml") as b:
bytewax_config = yaml.safe_load(b)
bytewax_config = yaml.load(b, Loader=yaml.Loader)

config = RepoConfig(**feast_config)
store = FeatureStore(config=config)
Expand Down