docs: Updated development guide to include compiling the protos #3896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com>
franciscojavierarceo
force-pushed
the
update-dev-guide
branch
from
4e91341 to
be7ce2b
Compare
franciscojavierarceo
changed the title
Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com>
Collaborator
|
maybe consider adding a brief description about spinning up feature server? 🤔 |
etirelli
approved these changes
Jan 30, 2024
tokoko
pushed a commit
to tokoko/feast
that referenced
this pull request
Feb 6, 2024
…t-dev#3896) * [docs] updated development guide to include compiling the protos Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com> * adding note on spinning up the docker image Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com> --------- Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com> Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
zseta
pushed a commit
to zseta/feast
that referenced
this pull request
Feb 7, 2024
…t-dev#3896) * [docs] updated development guide to include compiling the protos Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com> * adding note on spinning up the docker image Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com> --------- Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com> Signed-off-by: Attila Toth <hello@attilatoth.dev>
tqtensor
pushed a commit
to tqtensor/feast
that referenced
this pull request
Mar 11, 2024
…t-dev#3896) * [docs] updated development guide to include compiling the protos Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com> * adding note on spinning up the docker image Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com> --------- Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The development guide documentation omits compiling the protos but after building the source package you will observe a failure. It's sufficient to compile the protos so I have added this to the documentation.
Which issue(s) this PR fixes:
Fixes #