Skip to content

Remove alpha v1 from java package name#387

Merged
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
khorshuheng:remove-alpha-from-package-name
Dec 23, 2019
Merged

Remove alpha v1 from java package name#387
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
khorshuheng:remove-alpha-from-package-name

Conversation

@khorshuheng
Copy link
Copy Markdown
Collaborator

@khorshuheng khorshuheng commented Dec 23, 2019

The package should be renamed before publishing this to public Maven repository.

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Dec 23, 2019

Hi @khorshuheng. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@davidheryanto
Copy link
Copy Markdown
Collaborator

davidheryanto commented Dec 23, 2019

/ok-to-test

@davidheryanto
Copy link
Copy Markdown
Collaborator

davidheryanto commented Dec 23, 2019

/approve

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Dec 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto, khorshuheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidheryanto
Copy link
Copy Markdown
Collaborator

davidheryanto commented Dec 23, 2019

/lgtm

@feast-ci-bot feast-ci-bot merged commit 5fc779c into feast-dev:master Dec 23, 2019
khorshuheng added a commit to khorshuheng/feast that referenced this pull request Dec 23, 2019
@khorshuheng
Remove alpha v1 from java package name (feast-dev#387)
f808238
khorshuheng added a commit to khorshuheng/feast that referenced this pull request Dec 23, 2019
@khorshuheng
Remove alpha v1 from java package name (feast-dev#387)
5801e58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidheryanto davidheryanto Awaiting requested review from davidheryanto

@pradithya pradithya Awaiting requested review from pradithya

@woop woop Awaiting requested review from woop

@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@davidheryanto davidheryanto

Labels

approved lgtm ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khorshuheng @feast-ci-bot @davidheryanto