Skip to content

<doc>(README): add a link for user to view docs on GitBook#385

Merged
feast-ci-bot merged 2 commits intofeast-dev:masterfrom
david30907d:add-link-to-git-books
Jan 8, 2020
Merged

<doc>(README): add a link for user to view docs on GitBook#385
feast-ci-bot merged 2 commits intofeast-dev:masterfrom
david30907d:add-link-to-git-books

Conversation

@david30907d
Copy link
Copy Markdown
Contributor

@david30907d david30907d commented Dec 23, 2019

add a link for user to view docs on GitBook

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Dec 23, 2019

Hi @david30907d. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@david30907d david30907d mentioned this pull request Dec 23, 2019
Closed
woop
woop requested changes Dec 23, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@woop woop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not currently a part of Kubeflow, so not sure about linking to them yet.

@david30907d david30907d force-pushed the add-link-to-git-books branch from caae92f to 69535a6 Compare December 23, 2019 03:32
@david30907d
Copy link
Copy Markdown
Contributor Author

david30907d commented Dec 23, 2019

We're not currently a part of Kubeflow, so not sure about linking to them yet.

Oh, i'm sorry i know Feast is not part of kubeflow. I'm just want to use the same phrase of Kubeflow from its README but forgot to replace kubeflow.org with https://feast.dev.

Sorry for the offense 😓

@david30907d david30907d requested a review from woop December 23, 2019 03:38
@woop
Copy link
Copy Markdown
Member

woop commented Dec 23, 2019

We're not currently a part of Kubeflow, so not sure about linking to them yet.

Oh, i'm sorry i know Feast is not part of kubeflow. I'm just want to use the same phrase of Kubeflow from its README but forgot to replace kubeflow.org with https://feast.dev.

Sorry for the offense

Haha, no worries. Thanks for contributing!!

Would you mind signing the Google CLA before I merge this in?

https://cla.developers.google.com/clas

woop
woop previously approved these changes Dec 23, 2019
View reviewed changes
@david30907d
Copy link
Copy Markdown
Contributor Author

david30907d commented Dec 23, 2019

We're not currently a part of Kubeflow, so not sure about linking to them yet.

Oh, i'm sorry i know Feast is not part of kubeflow. I'm just want to use the same phrase of Kubeflow from its README but forgot to replace kubeflow.org with https://feast.dev.
Sorry for the offense

Haha, no worries. Thanks for contributing!!

Would you mind signing the Google CLA before I merge this in?

https://cla.developers.google.com/clas

sure, i would sign it right now~

@david30907d
Copy link
Copy Markdown
Contributor Author

david30907d commented Dec 23, 2019 •
edited
Loading

@woop i've signed the CLA~

@woop
Copy link
Copy Markdown
Member

woop commented Dec 23, 2019

/lgtm

@david30907d
Copy link
Copy Markdown
Contributor Author

david30907d commented Dec 23, 2019

/retest

@david30907d
Copy link
Copy Markdown
Contributor Author

david30907d commented Dec 23, 2019

/test test-end-to-end

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Dec 23, 2019

@david30907d: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Dec 23, 2019

@david30907d: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test test-end-to-end

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@david30907d david30907d requested a review from woop December 25, 2019 13:15
@woop
Copy link
Copy Markdown
Member

woop commented Jan 7, 2020

/retest

@woop
Copy link
Copy Markdown
Member

woop commented Jan 8, 2020

/ok-to-test

@woop woop requested a review from khorshuheng as a code owner January 8, 2020 02:09
@davidheryanto
Copy link
Copy Markdown
Collaborator

davidheryanto commented Jan 8, 2020 •
edited
Loading

/retest
Flaky tests because Feast core and serving was were not fully ready when tests were run.

@zhilingc
Copy link
Copy Markdown
Collaborator

zhilingc commented Jan 8, 2020

/lgtm

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Jan 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david30907d, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 1a00db1 into feast-dev:master Jan 8, 2020
@khorshuheng khorshuheng mentioned this pull request Feb 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes

@davidheryanto davidheryanto Awaiting requested review from davidheryanto

@pradithya pradithya Awaiting requested review from pradithya

@zhilingc zhilingc Awaiting requested review from zhilingc

@khorshuheng khorshuheng Awaiting requested review from khorshuheng

Assignees

@woop woop

@zhilingc zhilingc

Labels

approved lgtm ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@david30907d @feast-ci-bot @woop @davidheryanto @zhilingc