Skip to content

<docs>: remove GitBook plugin from README#384

Closed
david30907d wants to merge 1 commit intofeast-dev:masterfrom
david30907d:remove-gitbook-tag-from-readme
Closed

<docs>: remove GitBook plugin from README#384
david30907d wants to merge 1 commit intofeast-dev:masterfrom
david30907d:remove-gitbook-tag-from-readme

Conversation

@david30907d
Copy link
Copy Markdown
Contributor

just remove GitBook plugin from README because it doesn't render successfully

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: david30907d
To complete the pull request process, please assign pradithya
You can assign the PR to them by writing /assign @pradithya in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

Hi @david30907d. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop
Copy link
Copy Markdown
Member

woop commented Dec 23, 2019

Hi @david30907d

Thanks for the PR!

I am a little bit divided on whether to merge this. The markdown is still quite readable even with the Gitbook annotations. The advantage is that it's a lot more readable if you do use Gitbook.

Can you have a look at Feast Gitbook?

@david30907d
Copy link
Copy Markdown
Contributor Author

Hi @david30907d

Thanks for the PR!

I am a little bit divided on whether to merge this. The markdown is still quite readable even with the Gitbook annotations. The advantage is that it's a lot more readable if you do use Gitbook.

Can you have a look at Feast Gitbook?

Hi @woop , thanks for your reply, cause i didn't notice this GitBook page 😅
How about add a GitBook page for developer in case that they don't know Feast Gitbook ?

I've open a new PR for this #385 .

@david30907d david30907d deleted the remove-gitbook-tag-from-readme branch December 23, 2019 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants