Skip to content

fix: Bytewax engine create configmap from object #3821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
achals merged 1 commit into from
Nov 8, 2023
Merged

fix: Bytewax engine create configmap from object #3821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions sdk/python/feast/infra/materialization/contrib/bytewax/bytewax_materialization_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
from feast.infra.registry.base_registry import BaseRegistry
from feast.repo_config import FeastConfigBaseModel
from feast.stream_feature_view import StreamFeatureView
from feast.utils import _get_column_names, get_default_yaml_file_path
from feast.utils import _get_column_names

from .bytewax_materialization_job import BytewaxMaterializationJob

Expand Down Expand Up @@ -307,10 +307,7 @@ def _create_kubernetes_job(self, job_id, paths, feature_view):
def _create_configuration_map(self, job_id, paths, feature_view, namespace):
"""Create a Kubernetes configmap for this job"""

repo_path = self.repo_config.repo_path
assert repo_path
feature_store_path = get_default_yaml_file_path(repo_path)
feature_store_configuration = feature_store_path.read_text()
feature_store_configuration = yaml.dump(self.repo_config.dict())

materialization_config = yaml.dump(
{"paths": paths, "feature_view": feature_view.name}
Expand Down