Skip to content

fix: Remove parens from postgres source query #3807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
david-dest01 wants to merge 3 commits into from
Closed

fix: Remove parens from postgres source query #3807

david-dest01 wants to merge 3 commits into from

Conversation

@david-dest01
Copy link

@david-dest01 david-dest01 commented Oct 18, 2023

What this PR does / why we need it:
This PR removes the parens from a query in the PostgresSQLSource which were preventing it to successfully retrieve and materialize from table references.
 
Was previously not supported because of bug

source=PostgreSQLSource(
    name="source_user_events_v0",
    timestamp_field="created_at",
    table="offline_store.user_events"
)

 
Is now supported

source=PostgreSQLSource(
    name="source_user_events_v0",
    timestamp_field="created_at",
    table="offline_store.user_events"
)

source=PostgreSQLSource(
    name="source_user_events_v0",
    timestamp_field="created_at",
    query="select * from offline_store.user_events"
)

 
Which issue(s) this PR fixes:

Fixes #(#3804)

@david-dest01 david-dest01 changed the title fix:remove parents from postgres source query fix:remove parens from postgres source query Oct 18, 2023
@david-dest01 david-dest01 changed the title fix:remove parens from postgres source query fix: remove parens from postgres source query Oct 18, 2023
@achals achals changed the title fix: remove parens from postgres source query fix: Remove parens from postgres source query Oct 20, 2023
@david-dest01
Copy link
Author

david-dest01 commented Oct 28, 2023

@achals lmk if you need anything else here

@achals
Copy link
Member

achals commented Oct 29, 2023

@david-dest01 Do you mind fixing DCO? https://github.com/feast-dev/feast/pull/3807/checks?check_run_id=17817796280

@achals
Copy link
Member

achals commented Oct 29, 2023

Looks good to me otherwise

@david-dest01 david-dest01 mentioned this pull request Mar 20, 2024
Closed
@job-almekinders
Copy link
Contributor

job-almekinders commented Mar 21, 2024

Hey all, I've opened a similar PR #4026.

If any one of you has the time to take a look this would be highly appreciated! @achals @sudohainguyen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved lgtm ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@david-dest01 @achals @job-almekinders @sudohainguyen