Skip to content

Conversation

@zseta
Copy link
Contributor

@zseta zseta commented Jun 20, 2023

What this PR does / why we need it:

Add documentation about ScyllaDB and ScyllaDB Cloud as online store alternatives. ScyllaDB can use the already existing Cassandra connector.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zseta
To complete the pull request process, please assign hemidactylus after the PR has been reviewed.
You can assign the PR to them by writing /assign @hemidactylus in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zseta zseta changed the title Docs scylladb [docs] Add ScyllaDB as online store alternative Jun 20, 2023
@zseta zseta changed the title [docs] Add ScyllaDB as online store alternative docs: Add ScyllaDB as online store alternative Jun 20, 2023
@zseta
Copy link
Contributor Author

zseta commented Jun 27, 2023

/assign @hemidactylus

@hemidactylus
Copy link
Collaborator

/lgtm

@hemidactylus
Copy link
Collaborator

/approve

@HaoXuAI
Copy link
Collaborator

HaoXuAI commented Feb 7, 2024

@zseta Could you please pass the DCO? It's a good work👍

zseta and others added 19 commits February 7, 2024 11:02
Signed-off-by: Attila Toth <hello@attilatoth.dev>
Signed-off-by: Danny C <d.chiao@gmail.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
update Catalog argument in athena connector

Signed-off-by: Gyumin Lee <t1100394@T1100394PM01.local>
Co-authored-by: Gyumin Lee <t1100394@T1100394PM01.local>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
Signed-off-by: Danny C <d.chiao@gmail.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
ensure correct precedence with the two operators

Signed-off-by: Ben Fletcher <ben.fletcher@ft.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
Signed-off-by: Jiwon Park <bakjeeone@hotmail.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
…east-dev#3677)

Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.0.0 to 4.1.3.
- [Release notes](https://github.com/salesforce/tough-cookie/releases)
- [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md)
- [Commits](salesforce/tough-cookie@v4.0.0...v4.1.3)

---
updated-dependencies:
- dependency-name: tough-cookie
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.0.0 to 4.1.3.
- [Release notes](https://github.com/salesforce/tough-cookie/releases)
- [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md)
- [Commits](salesforce/tough-cookie@v4.0.0...v4.1.3)

---
updated-dependencies:
- dependency-name: tough-cookie
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
…east-dev#3630)

* sql.py data_sources.data_source_name String(255)

Extend the limit of the data_source_name field from 50 to 255.

Signed-off-by: Ross Donnachie <code@radonn.co.za>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
…east-dev#3680)

feat: Optimize bytes processed when retrieving entity df schema to 0

Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
…tore.plan() on python (feast-dev#3640)

* fix! KeyError: __dummy on entityless fv

Signed-off-by: williamfoschiera <william.foschiera@buser.com.br>

* fix! join_keys typing.

Signed-off-by: williamfoschiera <william.foschiera@buser.com.br>

---------

Signed-off-by: williamfoschiera <william.foschiera@buser.com.br>
Co-authored-by: williamfoschiera <william.foschiera@buser.com.br>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 7.1.1 to 7.2.4.
- [Release notes](https://github.com/protobufjs/protobuf.js/releases)
- [Changelog](https://github.com/protobufjs/protobuf.js/blob/master/CHANGELOG.md)
- [Commits](protobufjs/protobuf.js@protobufjs-v7.1.1...protobufjs-v7.2.4)

---
updated-dependencies:
- dependency-name: protobufjs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
…east-dev#3675)

Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 7.1.2 to 7.2.4.
- [Release notes](https://github.com/protobufjs/protobuf.js/releases)
- [Changelog](https://github.com/protobufjs/protobuf.js/blob/master/CHANGELOG.md)
- [Commits](protobufjs/protobuf.js@protobufjs-v7.1.2...protobufjs-v7.2.4)

---
updated-dependencies:
- dependency-name: protobufjs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
Bumps [semver](https://github.com/npm/node-semver) from 6.3.0 to 6.3.1.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v6.3.1/CHANGELOG.md)
- [Commits](npm/node-semver@v6.3.0...v6.3.1)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
…-dev#3679)

Bumps [semver](https://github.com/npm/node-semver) from 6.3.0 to 6.3.1.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v6.3.1/CHANGELOG.md)
- [Commits](npm/node-semver@v6.3.0...v6.3.1)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.47.0 to 1.53.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.47.0...v1.53.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
# [0.32.0](feast-dev/feast@v0.31.0...v0.32.0) (2023-07-17)

### Bug Fixes

* Added generic Feature store Creation for CLI ([feast-dev#3618](feast-dev#3618)) ([bf740d2](feast-dev@bf740d2))
* Broken non-root path with projects-list.json ([feast-dev#3665](feast-dev#3665)) ([4861af0](feast-dev@4861af0))
* Clean up snowflake to_spark_df() ([feast-dev#3607](feast-dev#3607)) ([e8e643e](feast-dev@e8e643e))
* Entityless fv breaks with `KeyError: __dummy` applying feature_store.plan() on python ([feast-dev#3640](feast-dev#3640)) ([ef4ef32](feast-dev@ef4ef32))
* Fix scan datasize to 0 for inference schema ([feast-dev#3628](feast-dev#3628)) ([c3dd74e](feast-dev@c3dd74e))
* Fix timestamp consistency in push api ([feast-dev#3614](feast-dev#3614)) ([9b227d7](feast-dev@9b227d7))
* For SQL registry, increase max data_source_name length to 255 ([feast-dev#3630](feast-dev#3630)) ([478caec](feast-dev@478caec))
* Implements connection pool for postgres online store ([feast-dev#3633](feast-dev#3633)) ([059509a](feast-dev@059509a))
* Manage redis pipe's context ([feast-dev#3655](feast-dev#3655)) ([48e0971](feast-dev@48e0971))
* Missing Catalog argument in athena connector ([feast-dev#3661](feast-dev#3661)) ([f6d3caf](feast-dev@f6d3caf))
* Optimize bytes processed when retrieving entity df schema to 0 ([feast-dev#3680](feast-dev#3680)) ([1c01035](feast-dev@1c01035))

### Features

* Add gunicorn for serve with multiprocess ([feast-dev#3636](feast-dev#3636)) ([4de7faf](feast-dev@4de7faf))
* Use string as a substitute for unregistered types during schema inference ([feast-dev#3646](feast-dev#3646)) ([c474ccd](feast-dev@c474ccd))

Signed-off-by: Attila Toth <hello@attilatoth.dev>
* Add fully-qualified-table-name Redshift prop

Signed-off-by: Robin Neufeld <metavee@users.noreply.github.com>

* pre-commit

Signed-off-by: Robin Neufeld <metavee@users.noreply.github.com>

* Docstring

Signed-off-by: Robin Neufeld <metavee@users.noreply.github.com>

* Test fully_qualified_table_name

Signed-off-by: Robin Neufeld <metavee@users.noreply.github.com>

* Simplify logic

Signed-off-by: Robin Neufeld <metavee@users.noreply.github.com>

* pre-commit

Signed-off-by: Robin Neufeld <metavee@users.noreply.github.com>

* pre-commit

Signed-off-by: Robin Neufeld <metavee@users.noreply.github.com>

* Test offline_write_batch

Signed-off-by: Robin Neufeld <metavee@users.noreply.github.com>

* Bump to trigger CI

Signed-off-by: Robin Neufeld <metavee@users.noreply.github.com>

* another bump for ci

Signed-off-by: Robin Neufeld <metavee@users.noreply.github.com>

---------

Signed-off-by: Robin Neufeld <metavee@users.noreply.github.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
…SA role (feast-dev#3696)

Add aws-sts dependency in java sdk

Signed-off-by: harmeet-singh-discovery <harmeet_singh@discovery.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
shuchu and others added 15 commits February 7, 2024 11:02
…ing CREATE sql command. Allow read-only user to call feast apply. (feast-dev#3851)

Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
…dev#3907)

Revert "fix: Verify the existence of Registry tables in snowflake before calling CREATE sql command. Allow read-only user to call feast apply. (feast-dev#3851)"

This reverts commit 9a3590e.

Signed-off-by: Edson Tirelli <etirelli@redhat.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
Adds support for arrays in snowflake

Signed-off-by: john.lemmon <john.lemmon@medely.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
…ization (feast-dev#3891)

Signed-off-by: Attila Toth <hello@attilatoth.dev>
…feast-dev#3905)

Update mysql.py to create index only if not exists during update

Signed-off-by: senbong <senbong@featurebyte.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
…yaml (feast-dev#3912)

* bytewax materialization loads yaml config correctly

Signed-off-by: marti-jorda-roca <mjorda98@gmail.com>

* added postgres dependency for SQL registries

Signed-off-by: marti-jorda-roca <mjorda98@gmail.com>

---------

Signed-off-by: marti-jorda-roca <mjorda98@gmail.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
…t-dev#3896)

* [docs] updated development guide to include compiling the protos

Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com>

* adding note on spinning up the docker image

Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com>

---------

Signed-off-by: franciscojavierarceo <francisco.arceo@affirm.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
…ts (feast-dev#3895)

Signed-off-by: Attila Toth <hello@attilatoth.dev>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
chore: set upper bound for moto package

Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Attila Toth <hello@attilatoth.dev>
@zseta
Copy link
Contributor Author

zseta commented Feb 7, 2024

@HaoXuAI Done (I hope I did it correctly).

@jeremyary
Copy link
Collaborator

Hey @zseta unfortunately it seems to me that the commit's still failing DCO. More details identifying the commit & steps can be found here. Once resolved, we should see sign-off info on the commit similar to this screenshot from a random recent merged commit here (just as an example)
image

@zseta
Copy link
Contributor Author

zseta commented Feb 7, 2024

Any chance I can just open a new PR with the same changes? I'm having issues with DCO so it would be easier..🙏

@jeremyary
Copy link
Collaborator

Any chance I can just open a new PR with the same changes? I'm having issues with DCO so it would be easier..🙏

Seems ok to me, I've been known to do similar when I distrust my local repo state :) any considerations I'm overlooking that come to mind @HaoXuAI ?

@HaoXuAI
Copy link
Collaborator

HaoXuAI commented Feb 7, 2024

Any chance I can just open a new PR with the same changes? I'm having issues with DCO so it would be easier..🙏

Seems ok to me, I've been known to do similar when I distrust my local repo state :) any considerations I'm overlooking that come to mind @HaoXuAI ?

nope, definitely not a concern. go ahead to open another one

@zseta
Copy link
Contributor Author

zseta commented Feb 9, 2024

Opened a new PR with proper DCO

@zseta zseta closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.