feat: Add possibility to save dataset as table, when spark config has remote warehouse info #3645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remote warehouse info Signed-off-by: nsuraeva <nsuraeva@neoflex.ru>
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nadejdaSuraeva The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
nadejdaSuraeva
changed the title
felixwang9817
pushed a commit
that referenced
this pull request
Aug 14, 2023
# [0.33.0](v0.32.0...v0.33.0) (2023-08-14) ### Bug Fixes * Add aws-sts dependency in java sdk so that S3 client acquires IRSA role ([#3696](#3696)) ([c75a01f](c75a01f)) * Redshift push ignores schema ([#3671](#3671)) ([76270f6](76270f6)) ### Features * Add possibility to save dataset as table, when spark config has remote warehouse info ([#3645](#3645)) ([22c109b](22c109b))
zseta
pushed a commit
to zseta/feast
that referenced
this pull request
Feb 7, 2024
… remote warehouse info (feast-dev#3645) feat: add possibility to save dataset as table, when spark config has remote warehouse info Signed-off-by: nsuraeva <nsuraeva@neoflex.ru> Co-authored-by: nsuraeva <nsuraeva@neoflex.ru> Signed-off-by: Attila Toth <hello@attilatoth.dev>
zseta
pushed a commit
to zseta/feast
that referenced
this pull request
Feb 7, 2024
# [0.33.0](feast-dev/feast@v0.32.0...v0.33.0) (2023-08-14) ### Bug Fixes * Add aws-sts dependency in java sdk so that S3 client acquires IRSA role ([feast-dev#3696](feast-dev#3696)) ([c75a01f](feast-dev@c75a01f)) * Redshift push ignores schema ([feast-dev#3671](feast-dev#3671)) ([76270f6](feast-dev@76270f6)) ### Features * Add possibility to save dataset as table, when spark config has remote warehouse info ([feast-dev#3645](feast-dev#3645)) ([22c109b](feast-dev@22c109b)) Signed-off-by: Attila Toth <hello@attilatoth.dev>
EXPEbdodla
pushed a commit
to ExpediaGroup/feast
that referenced
this pull request
Jun 10, 2024
… remote warehouse info (feast-dev#3645) feat: add possibility to save dataset as table, when spark config has remote warehouse info Signed-off-by: nsuraeva <nsuraeva@neoflex.ru> Co-authored-by: nsuraeva <nsuraeva@neoflex.ru>
EXPEbdodla
pushed a commit
to ExpediaGroup/feast
that referenced
this pull request
Jun 10, 2024
# [0.33.0](feast-dev/feast@v0.32.0...v0.33.0) (2023-08-14) ### Bug Fixes * Add aws-sts dependency in java sdk so that S3 client acquires IRSA role ([feast-dev#3696](feast-dev#3696)) ([c75a01f](feast-dev@c75a01f)) * Redshift push ignores schema ([feast-dev#3671](feast-dev#3671)) ([76270f6](feast-dev@76270f6)) ### Features * Add possibility to save dataset as table, when spark config has remote warehouse info ([feast-dev#3645](feast-dev#3645)) ([22c109b](feast-dev@22c109b))
EXPEbdodla
pushed a commit
to ExpediaGroup/feast
that referenced
this pull request
Jun 11, 2024
… remote warehouse info (feast-dev#3645) feat: add possibility to save dataset as table, when spark config has remote warehouse info Signed-off-by: nsuraeva <nsuraeva@neoflex.ru> Co-authored-by: nsuraeva <nsuraeva@neoflex.ru>
EXPEbdodla
pushed a commit
to ExpediaGroup/feast
that referenced
this pull request
Jun 11, 2024
# [0.33.0](feast-dev/feast@v0.32.0...v0.33.0) (2023-08-14) ### Bug Fixes * Add aws-sts dependency in java sdk so that S3 client acquires IRSA role ([feast-dev#3696](feast-dev#3696)) ([c75a01f](feast-dev@c75a01f)) * Redshift push ignores schema ([feast-dev#3671](feast-dev#3671)) ([76270f6](feast-dev@76270f6)) ### Features * Add possibility to save dataset as table, when spark config has remote warehouse info ([feast-dev#3645](feast-dev#3645)) ([22c109b](feast-dev@22c109b))
EXPEbdodla
added a commit
to ExpediaGroup/feast
that referenced
this pull request
Jun 11, 2024
…nfig has remote warehouse info (feast-dev#3645)" This reverts commit c3ceb8c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a possibility to use saved_dataset as a table for different spark session. The existing solution saves the dataset’s name in registry, but the data exists only within the scope of the spark session.
Which issue(s) this PR fixes:
Fixes #3644