Skip to content

Conversation

@sfc-gh-madkins
Copy link
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3567 #3580

Signed-off-by: Miles Adkins <miles.adkins@snowflake.com>
@sfc-gh-madkins
Copy link
Collaborator Author

/ok-to-test

@sfc-gh-madkins
Copy link
Collaborator Author

@adchia this should be good to push through

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, sfc-gh-madkins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [felixwang9817,sfc-gh-madkins]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felixwang9817 felixwang9817 disabled auto-merge April 24, 2023 16:06
@felixwang9817 felixwang9817 merged commit ebcdc36 into feast-dev:master Apr 24, 2023
@sfc-gh-madkins sfc-gh-madkins deleted the upgrade_snowflak_version branch April 24, 2023 16:30
zerafachris pushed a commit to zerafachris/feast that referenced this pull request Mar 5, 2024
Signed-off-by: Miles Adkins <miles.adkins@snowflake.com>
Signed-off-by: zerafachris PERSONAL <zerafachris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Could not import module 'feast.infra.offline_stores.snowflake' while attempting to load class 'SnowflakeOfflineStoreConfig'

3 participants