Update Feast Core API to support Project namespacing#359
Update Feast Core API to support Project namespacing#359woop wants to merge 4 commits intofeast-dev:project-isolationfrom
Conversation
woop
requested review from
davidheryanto,
pradithya,
thirteen37,
tims and
zhilingc
as code owners
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| message ApplyFeatureSetRequest { | ||
| // Name of project that the feature set belongs to. | ||
| string project = 2; |
There was a problem hiding this comment.
Will this becomes a mandatory parameter?
| } | ||
|
|
||
| // Request for the archival of a project | ||
| message ArchiveProjectRequest { |
There was a problem hiding this comment.
What happens to the features ingested when a project is archived?
There was a problem hiding this comment.
It continues to work. Ingestion is unaffected.
|
I just realized that we should probably change the test scripts to also code gen from protos. Right now these tests are passing but they shouldnt. cc @davidheryanto @zhilingc |
Updated Golang SDK to Feast Serving API
|
@woop: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Should we have a spec for the project name? For example,
So that when we're combining project name with feature name, there won't be ambiguity (e.g. if we use colon as a separator and project name includes colon as well). And the storage system where we persist the project name information may only support certain character sets, e.g. ASCII but not Unicode. And if we plan to use the project name in some URI, probably it should be DNS friendly too? |
Yip, makes sense. Where should this be documented? |
4 participants
Updated Feast Core gRPC API based on: Feast Projects RFC
This will be one of many PRs to the
project-isolationbranch. I am purposefully not merging this into master (as that will break master) and not building one massive PR (which will be too hard to parse).