Skip to content

fix: Update registry.refresh to have a default arg #3450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 1 commit into from
Jan 18, 2023
Merged

fix: Update registry.refresh to have a default arg #3450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,7 @@ def plan(

# Compute the desired difference between the current infra, as stored in the registry,
# and the desired infra.
self._registry.refresh(self.project)
self._registry.refresh(project=self.project)
current_infra_proto = self._registry.proto().infra.__deepcopy__()
desired_registry_proto = desired_repo_contents.to_registry_proto()
new_infra = self._provider.plan_infra(self.config, desired_registry_proto)
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/registry/base_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ def commit(self):
"""Commits the state of the registry cache to the remote registry store."""

@abstractmethod
def refresh(self, project: Optional[str]):
def refresh(self, project: Optional[str] = None):
"""Refreshes the state of the registry cache by fetching the registry state from the remote registry store."""

@staticmethod
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/registry/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,7 +776,7 @@ def commit(self):
if self.cached_registry_proto:
self._registry_store.update_registry_proto(self.cached_registry_proto)

def refresh(self, project: Optional[str]):
def refresh(self, project: Optional[str] = None):
"""Refreshes the state of the registry cache by fetching the registry state from the remote registry store."""
self._get_registry_proto(project=project, allow_cache=False)

Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/registry/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def teardown(self):
stmt = delete(t)
conn.execute(stmt)

def refresh(self, project: Optional[str]):
def refresh(self, project: Optional[str] = None):
self.cached_registry_proto = self.proto()
self.cached_registry_proto_created = datetime.utcnow()

Expand Down