Skip to content

fix: Fix UI build #3274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jerive wants to merge 1 commit into from
Closed

fix: Fix UI build #3274

jerive wants to merge 1 commit into from

Conversation

@jerive
Copy link
Contributor

@jerive jerive commented Oct 6, 2022

What this PR does / why we need it:
Zod to protobuf passed but UI build was failing. This fixes it.

Which issue(s) this PR fixes:
Fixes #3273

@jerive jerive requested a review from adchia as a code owner October 6, 2022 11:12
@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Oct 6, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jerive
To complete the pull request process, please assign achals after the PR has been reviewed.
You can assign the PR to them by writing /assign @achals in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022 •
edited
Loading

Codecov Report

Base: 67.53% // Head: 57.93% // Decreases project coverage by -9.59% ⚠️

Coverage data is based on head (f15caba) compared to base (eff01d1).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3274      +/-   ##
==========================================
- Coverage   67.53%   57.93%   -9.60%     
==========================================
  Files         181      215      +34     
  Lines       16514    18062    +1548     
==========================================
- Hits        11152    10464     -688     
- Misses       5362     7598    +2236
Flag Coverage Δ
integrationtests ?
unittests 57.93% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sts/integration/registration/test_universal_cli.py 20.20% <0.00%> (-79.80%) ⬇️
...ts/integration/offline_store/test_offline_write.py 26.08% <0.00%> (-73.92%) ⬇️
...fline_store/test_universal_historical_retrieval.py 28.75% <0.00%> (-71.25%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.55% <0.00%> (-69.30%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 31.34% <0.00%> (-68.66%) ⬇️
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 28.39% <0.00%> (-66.58%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
...n/tests/integration/registration/test_inference.py 35.71% <0.00%> (-64.29%) ⬇️
... and 171 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jerive jerive changed the title Fix UI build fix: Fix UI build Oct 6, 2022
@jerive jerive force-pushed the fix_ui_build_after_proto branch 2 times, most recently from aa45d94 to ee72899 Compare October 6, 2022 11:37
@feast-ci-bot feast-ci-bot added size/M and removed size/S labels Oct 6, 2022
@jerive jerive force-pushed the fix_ui_build_after_proto branch from ee72899 to 63525c1 Compare October 6, 2022 11:46
@kevjumba
Copy link
Collaborator

kevjumba commented Oct 6, 2022

@jerive Is this different than danny's changes?

@jerive
Copy link
Contributor Author

jerive commented Oct 6, 2022

We did it in parallel and in the end Danny won :)
I will close this one.

@jerive jerive closed this Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adchia adchia Awaiting requested review from adchia

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jerive @feast-ci-bot @codecov-commenter @kevjumba @jerome-viveret-onfido