Skip to content

chore: Update snowflake dependencies #3238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-madkins merged 1 commit into from
Sep 22, 2022
Merged

chore: Update snowflake dependencies #3238

sfc-gh-madkins merged 1 commit into from
Sep 22, 2022

Conversation

@sfc-gh-madkins
Copy link
Collaborator

@sfc-gh-madkins sfc-gh-madkins commented Sep 20, 2022

Signed-off-by: miles.adkins miles.adkins@snowflake.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3237

achals
achals approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Sep 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, sfc-gh-madkins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals
Copy link
Member

achals commented Sep 20, 2022

You'll have to update the requirements.txt files

@sfc-gh-madkins sfc-gh-madkins enabled auto-merge (squash) September 20, 2022 19:17
@sfc-gh-madkins
Copy link
Collaborator Author

sfc-gh-madkins commented Sep 20, 2022

@achals running the reqs updates doesnt change anything?

@sfc-gh-madkins
chore: Update snowflake python dependencies
a93f2a6 
Signed-off-by: miles.adkins <miles.adkins@snowflake.com>
@feast-ci-bot feast-ci-bot removed the lgtm label Sep 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2022 •
edited
Loading

Codecov Report

Base: 67.31% // Head: 76.87% // Increases project coverage by +9.56% 🎉

Coverage data is based on head (a93f2a6) compared to base (769c318).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3238      +/-   ##
==========================================
+ Coverage   67.31%   76.87%   +9.56%     
==========================================
  Files         179      213      +34     
  Lines       16278    18079    +1801     
==========================================
+ Hits        10958    13899    +2941     
+ Misses       5320     4180    -1140
Flag Coverage Δ
integrationtests 67.32% <ø> (+<0.01%) ⬆️
unittests 58.26% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
.../python/feast/infra/feature_servers/base_config.py 100.00% <0.00%> (ø)
...n/feast/infra/feature_servers/aws_lambda/config.py 100.00% <0.00%> (ø)
...line_stores/contrib/athena_offline_store/athena.py 38.50% <0.00%> (ø)
.../online_stores/contrib/hbase_online_store/hbase.py 37.25% <0.00%> (ø)
.../contrib/postgres_offline_store/postgres_source.py 50.66% <0.00%> (ø)
...s/contrib/postgres_offline_store/tests/__init__.py 100.00% <0.00%> (ø)
.../contrib/athena_offline_store/tests/data_source.py 46.66% <0.00%> (ø)
...ontrib/postgres_offline_store/tests/data_source.py 51.02% <0.00%> (ø)
...ores/contrib/mssql_offline_store/tests/__init__.py 100.00% <0.00%> (ø)
... and 108 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@felixwang9817
Copy link
Collaborator

felixwang9817 commented Sep 22, 2022

/lgtm

@sfc-gh-madkins sfc-gh-madkins enabled auto-merge (squash) September 22, 2022 01:26
@sfc-gh-madkins sfc-gh-madkins merged commit 2624879 into feast-dev:master Sep 22, 2022
@sfc-gh-madkins sfc-gh-madkins deleted the reqs branch September 22, 2022 18:57
vmallya-123 pushed a commit to vmallya-123/feast that referenced this pull request Sep 27, 2022
@sfc-gh-madkins @vmallya-123
chore: Update snowflake dependencies (feast-dev#3238)
3329af3 
chore: Update snowflake python dependencies

Signed-off-by: miles.adkins <miles.adkins@snowflake.com>

Signed-off-by: miles.adkins <miles.adkins@snowflake.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

Assignees

@achals achals

@felixwang9817 felixwang9817

Labels

approved lgtm ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow snowflake-connector-python >= 2.7.8

5 participants

@sfc-gh-madkins @feast-ci-bot @achals @codecov-commenter @felixwang9817