Skip to content

chore: Fix header levels in feature retrieval page #3225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
feast-ci-bot merged 1 commit into from
Sep 22, 2022
Merged

chore: Fix header levels in feature retrieval page #3225

feast-ci-bot merged 1 commit into from
Sep 22, 2022

Conversation

@adchia
Copy link
Collaborator

@adchia adchia commented Sep 15, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@adchia
chore: Fix header levels in feature retrieval page
c4fd49b 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022 •
edited
Loading

Codecov Report

Base: 67.31% // Head: 76.85% // Increases project coverage by +9.53% 🎉

Coverage data is based on head (c4fd49b) compared to base (59b4853).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3225      +/-   ##
==========================================
+ Coverage   67.31%   76.85%   +9.53%     
==========================================
  Files         179      213      +34     
  Lines       16276    18076    +1800     
==========================================
+ Hits        10956    13892    +2936     
+ Misses       5320     4184    -1136
Flag Coverage Δ
integrationtests 67.31% <ø> (+<0.01%) ⬆️
unittests 58.24% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/feast/infra/feature_servers/base_config.py 100.00% <0.00%> (ø)
...n/feast/infra/feature_servers/aws_lambda/config.py 100.00% <0.00%> (ø)
...tion/feature_repos/universal/online_store/hbase.py 50.00% <0.00%> (ø)
.../online_stores/contrib/hbase_repo_configuration.py 100.00% <0.00%> (ø)
...tores/contrib/trino_offline_store/trino_queries.py 15.05% <0.00%> (ø)
...ffline_stores/contrib/trino_offline_store/trino.py 8.78% <0.00%> (ø)
...ffline_stores/contrib/athena_repo_configuration.py 100.00% <0.00%> (ø)
...line_stores/contrib/postgres_repo_configuration.py 100.00% <0.00%> (ø)
...s/contrib/mssql_offline_store/tests/data_source.py 46.93% <0.00%> (ø)
...ores/contrib/trino_offline_store/trino_type_map.py 6.66% <0.00%> (ø)
... and 107 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

felixwang9817
felixwang9817 approved these changes Sep 20, 2022
View reviewed changes
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Sep 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 357f3e9 into feast-dev:master Sep 22, 2022
vmallya-123 pushed a commit to vmallya-123/feast that referenced this pull request Sep 27, 2022
@adchia @vmallya-123
chore: Fix header levels in feature retrieval page (feast-dev#3225)
98644b8 
Signed-off-by: Danny Chiao <danny@tecton.ai>

Signed-off-by: Danny Chiao <danny@tecton.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixwang9817 felixwang9817 felixwang9817 approved these changes

Assignees

@felixwang9817 felixwang9817

Labels

approved lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adchia @codecov-commenter @feast-ci-bot @felixwang9817