Skip to content

fix: Feature-server image is missing mysql dependency for mysql registry #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 4 commits into from
Sep 15, 2022
Merged

fix: Feature-server image is missing mysql dependency for mysql registry #3223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a3aa18
add requirements.txt and add mysqlclient package
ptran32 Sep 15, 2022
8e7b331
use feast[mysql] in requirements.txt
ptran32 Sep 15, 2022
1b60833
add feast components
ptran32 Sep 15, 2022
6b283a6
add native libraries needed by mysqlclient
ptran32 Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions sdk/python/feast/infra/feature_servers/multicloud/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@
FROM python:3.8

RUN apt update && \
apt install -y jq
apt install -y \
jq \
python3-dev \
default-libmysqlclient-dev \
build-essential

RUN pip install pip --upgrade
RUN pip install "feast[aws,gcp,snowflake,redis,go]"
COPY . .

RUN pip install -r requirements.txt
RUN apt update
RUN apt install -y -V ca-certificates lsb-release wget
RUN wget https://apache.jfrog.io/artifactory/arrow/$(lsb_release --id --short | tr 'A-Z' 'a-z')/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb
Expand Down
9 changes: 7 additions & 2 deletions sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
FROM python:3.8

RUN apt update && \
apt install -y jq
apt install -y \
jq \
python3-dev \
default-libmysqlclient-dev \
build-essential

RUN pip install pip --upgrade
COPY . .

RUN pip install ".[aws,gcp,snowflake,redis,go]"
RUN pip install -r requirements.txt
RUN apt update
RUN apt install -y -V ca-certificates lsb-release wget
RUN wget https://apache.jfrog.io/artifactory/arrow/$(lsb_release --id --short | tr 'A-Z' 'a-z')/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb
Expand Down
1 change: 1 addition & 0 deletions sdk/python/feast/infra/feature_servers/multicloud/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
feast[aws,gcp,snowflake,redis,go,mysql]